Skip to content

Use the first release of each minor version for the policy #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
headtr1ck wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use the first release of each minor version for the policy #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions minimum_versions/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,21 @@ def is_suitable_release(release):
if release.timestamp is None:
return False

segments = release.version.extend_to_length(3).segments()
segments = release.version.segments()

return segments[2] == [0]
return all(isinstance(part, int) for segment in segments for part in segment)


def first_release_of_each_minor(releases):
# not every minor version has a x.y.0 release (e.g. netcdf4 1.7 starts at
# 1.7.1), so use the first release of each minor version instead
first_releases = {}
for release in sorted(releases):
segments = release.version.extend_to_length(2).segments()
minor = tuple(tuple(segment) for segment in segments[:2])
first_releases.setdefault(minor, release)

return sorted(first_releases.values(), key=lambda release: release.timestamp)


@dataclass
Expand All @@ -80,9 +92,9 @@ def minimum_version(self, today, package_name, releases):
if (override := self.overrides.get(package_name)) is not None:
return find_release(releases, version=override)

suitable_releases = [
suitable_releases = first_release_of_each_minor(
release for release in releases if is_suitable_release(release)
]
)
if not suitable_releases:
raise ValueError(f"Cannot find valid releases for {package_name}")

Expand Down
21 changes: 21 additions & 0 deletions minimum_versions/tests/test_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,20 @@
dt.date(2024, 9, 5),
Release(Version("1.1.1"), 0, dt.datetime(2023, 12, 1)),
),
pytest.param(
"netcdf4",
Policy({}, 12, {}),
dt.date(2025, 9, 1),
Release(Version("1.7.1"), 0, dt.datetime(2024, 6, 18)),
id="no-x.y.0-release",
),
pytest.param(
"netcdf4",
Policy({}, 12, {}),
dt.date(2024, 9, 1),
Release(Version("1.6.0"), 0, dt.datetime(2022, 6, 29)),
id="no-x.y.0-release-too-recent",
),
),
)
def test_policy_minimum_version(package_name, policy, today, expected):
Expand All @@ -49,6 +63,13 @@ def test_policy_minimum_version(package_name, policy, today, expected):
Release(Version("1.2.0"), 0, dt.datetime(2024, 1, 3)),
Release(Version("1.2.1"), 0, dt.datetime(2024, 2, 5)),
],
"netcdf4": [
Release(Version("1.6.0"), 0, dt.datetime(2022, 6, 29)),
Release(Version("1.6.5"), 0, dt.datetime(2023, 10, 20)),
Release(Version("1.7.0rc1"), 0, dt.datetime(2024, 5, 1)),
Release(Version("1.7.1"), 0, dt.datetime(2024, 6, 18)),
Release(Version("1.7.2"), 0, dt.datetime(2024, 10, 22)),
],
}

actual = policy.minimum_version(today, package_name, releases[package_name])
Expand Down