Skip to content

Drop global Rust reader runtime #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xando merged 1 commit into from
Jun 9, 2026
Merged

Drop global Rust reader runtime #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions rust/src/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// `pyarrow.RecordBatch` objects drained from the Rust channel.

use std::sync::Arc;
use std::sync::OnceLock;

use arrow::buffer::Buffer as ArrowBuffer;
use arrow::ipc::reader::StreamDecoder;
Expand Down Expand Up @@ -40,15 +39,12 @@ const SCOPE: &[&str] = &["https://www.googleapis.com/auth/bigquery.readonly"];
const MAX_DECODING_MESSAGE_SIZE: usize = 256 * 1024 * 1024;
const MAX_READ_ROWS_RETRIES: usize = 3;

fn runtime() -> &'static Runtime {
static RT: OnceLock<Runtime> = OnceLock::new();
RT.get_or_init(|| {
Builder::new_multi_thread()
.enable_all()
.thread_name("pyarrow-bigquery-rs")
.build()
.expect("failed to build tokio runtime")
})
fn build_runtime() -> Result<Runtime, String> {
Builder::new_multi_thread()
.enable_all()
.thread_name("pyarrow-bigquery-rs")
.build()
.map_err(|e| format!("tokio runtime: {e}"))
}

#[derive(Clone)]
Expand Down Expand Up @@ -249,6 +245,7 @@ pub struct PyReader {
rx: Option<mpsc::Receiver<Result<RecordBatch, String>>>,
batch_size: usize,
schema_ipc: Vec<u8>,
_runtime: Runtime,
}

#[pymethods]
Expand Down Expand Up @@ -293,7 +290,7 @@ impl PyReader {
);
let compression = compression_from_str(compression.as_deref());

let rt = runtime();
let rt = build_runtime().map_err(PyRuntimeError::new_err)?;
let (schema_ipc, streams, token) = py.allow_threads(|| {
rt.block_on(async {
let token = fetch_token().await?;
Expand Down Expand Up @@ -343,6 +340,7 @@ impl PyReader {
rx: Some(rx),
batch_size,
schema_ipc,
_runtime: rt,
})
}

Expand Down
Loading