Repository navigation
Conversation
wai-bao
requested review from
DongheJin,
DragonFive,
JimHsiung,
Kang-Meng,
XuZhang99,
liutongxuan,
xiao-yu-chen,
yingxudeng and
zhang-minchao
as code owners
October 20, 2026 23:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
wai-bao
marked this pull request as draft
October 20, 2026 23:13
wai-bao
force-pushed
the
refactor/unify-engine-ownership
branch
from
October 20, 2026 23:24
e8c8db7 to
ef61631
Compare
wai-bao
marked this pull request as ready for review
October 20, 2026 23:27
wai-bao
marked this pull request as draft
October 21, 2026 04:57
wai-bao
force-pushed
the
refactor/unify-engine-ownership
branch
16 times, most recently
from
October 23, 2026 05:46
b13640e to
8783c79
Compare
wai-bao
force-pushed
the
refactor/unify-engine-ownership
branch
17 times, most recently
from
October 24, 2026 09:06
1aaf79e to
1ed929e
Compare
wai-bao
force-pushed
the
refactor/unify-engine-ownership
branch
from
October 24, 2026 11:41
1ed929e to
1769d7a
Compare
wai-bao
force-pushed
the
refactor/unify-engine-ownership
branch
9 times, most recently
from
October 25, 2026 16:37
9cdd4dc to
204244c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify LLM/VLM target and draft resources under concrete engines and remove the speculative engine wrappers. Schedulers and profiling share one non-template implementation through scheduler callbacks.
is_draft_engineconsistently and remove unused and test-only production interfaces.