gateway-controller: envoy xDS and policy xDS mutual TLS support - #3328
Open
tharindu1st wants to merge 1 commit into
Open
gateway-controller: envoy xDS and policy xDS mutual TLS support#3328tharindu1st wants to merge 1 commit into
tharindu1st wants to merge 1 commit into
Conversation
Adds PQC-capable mutual TLS to both xDS gRPC servers: the main Envoy-facing xDS server (server.xds_tls) and the policy-engine-facing policy xDS server (policy_server.tls), reusing the same XDSServerTLSConfig shape and BuildXDSServerTLSConfig/ValidateXDSServerTLS helpers for both. Includes peer identity verification (tlsauth) for mTLS client allowlisting, and the policy-engine xdsclient-side TLS support to connect to the now-mTLS-capable policy xDS server. Extracted from PR wso2#3222.
tharindu1st
requested review from
AnuGayan,
Arshardh,
CrowleyRajapakse,
HeshanSudarshana,
HiranyaKavishani,
Induwara04,
Krishanx92,
PasanT9,
Piumal1999,
RakhithaRR,
Tharsanan1,
Thushani-Jayasekera,
VirajSalaka,
ashera96,
chamilaadhi,
dushaniw,
hisanhunais,
lasanthaS,
malinthaprasan,
pubudu538,
renuka-fernando,
senthuran16,
tgtshanika,
tharikaGitHub and
thivindu
as code owners
August 28, 2026 09:13
Contributor
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (18)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.xds_tls) and the policy-engine-facing policy xDS server (policy_server.tls), both configured via the sharedXDSServerTLSConfigshape (PQC-capable cipher/curve config, off by default).pkg/tlsauthfor verifying the mTLS peer identity against an allowlist.xdsclient-side TLS support so it can connect to the now-mTLS-capable policy xDS server.pkg/config/server_tls.goandgateway-runtime/policy-engine/internal/config/admin_tls.goas prerequisites — these are pure TLS-parsing utility functions (cipher/curve/version parsing) shared with the REST-API-TLS work in support PQC supported ciphers and ECDH curves from envoy #3222, not REST-API-specific themselves.server.tls,cmd/controller/server_tls.go) andgateway/configs/config-template.tomldocumentation — those belong to the REST API TLS PR being extracted separately, and the template doc forxds_tls/policy_server.tlsis interleaved with that REST TLS doc in a way that isn't cleanly splittable without hand-editing docs.Merge-order note
policyxds.WithTLStopolicyxds.WithMTLS.event-gateway/gateway-controller(onmaintoday) still callspolicyxds.WithTLSand will fail to build if this PR merges before the sibling "event-gateway related changes" PR (event-gateway: shared httpclient, PQC cipher/curve config, and xDS mTLS support #3327), which already updates that call site. Recommend merging event-gateway: shared httpclient, PQC cipher/curve config, and xDS mTLS support #3327 first, or coordinate the merge order.Test plan
go build ./...,go vet ./...,go test ./...pass forgateway/gateway-controllergo build ./...,go vet ./...,go test ./...pass forgateway/gateway-runtime/policy-engine