Skip to content

Test: add IT scenario for match condition on keyExtraction for advanced-ratelimit policy - #3325

Open
Saadha123 wants to merge 1 commit into
wso2:mainfrom
Saadha123:feature/ratelimit-match-condition-it-test
Open

Test: add IT scenario for match condition on keyExtraction for advanced-ratelimit policy#3325
Saadha123 wants to merge 1 commit into
wso2:mainfrom
Saadha123:feature/ratelimit-match-condition-it-test

Conversation

@Saadha123

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Ran locally, scoped to this feature file: IT_FEATURE_PATHS=features/ratelimit.feature COMPOSE_FILE=docker-compose.test.yaml go test -v ./... — 43 scenarios / 577 steps, all passed, including the new scenario.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9167a24e-8e74-4557-af93-21a307a53138

📥 Commits

Reviewing files that changed from the base of the PR and between 5fed476 and 7b9ba7c.

📒 Files selected for processing (1)
  • gateway/it/features/ratelimit.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The integration test adds regex-based header key matching for rate limiting. It verifies separate quotas for guest-* and channel-partner, while internal-app-1 bypasses the quota.

Changes

Rate-limit matching

Layer / File(s) Summary
Regex header rate-limit scenario
gateway/it/features/ratelimit.feature
Adds coverage for regex-based matching of extracted header keys. Matching values receive independent three-request quotas. The non-matching internal-app-1 value remains unrestricted.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7b9ba

This change adds coverage for advanced rate-limit key matching, and the reported scoped test run passes; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: anugayan, arshardh, ashera96

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the test purpose and reports successful execution, but it omits most required template sections, including Goals, Approach, User stories, Documentation, Automation tests detai… Update the description to include all required template sections. Mark non-applicable sections with N/A and provide the required security confirmations, test coverage details, related issue or PR references, and test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of an integration test scenario for the match condition on keyExtraction in the advanced-ratelimit policy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the test purpose and reports successful execution, but it omits most required template sections, including Goals, Approach, User stories, Documentation, Automation tests details, Security checks, Samples, Related PRs, and Test environment.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Saadha123 Saadha123 changed the title test(ratelimit): add IT scenario for match condition on keyExtraction Test: add IT scenario for match condition on keyExtraction for advanced-ratelimit policy Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant