Add asset selector (XLM + USDC) and trustline-aware flows to Stellar Send and Receive pages, using the SDK's build SendStellarAsset.#94
Closed
DevScoopee wants to merge 1 commit into
Conversation
|
@DevScoopee is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Welcome back @DevScoopee! The new work looks much better aligned with #65 (asset selector + trustline-aware flows). After #93 just landed, conflicts on StellarReceive, StellarSend, and WalletConnect: git fetch origin
git rebase origin/develop
# For all 3 files: keep develop's telemetry import and re-apply your asset-selector additions on top
git add -u
git rebase --continue
git push --force-with-leaseAlso: I had unassigned you from #65 yesterday (when #79 closed) but feel free to take it back since you're delivering on it now. I'll re-assign after merge. |
Contributor
Author
|
Hi, i have delivered the job and sent a pull request. kindly review and
merge
…On Sun, 28 Jun 2026 at 09:32, truthixify ***@***.***> wrote:
*truthixify* left a comment (wraith-protocol/demo#94)
<#94 (comment)>
Welcome back @DevScoopee <https://github.com/DevScoopee>! The new work
looks much better aligned with #65
<#65> (asset selector +
trustline-aware flows). After #93
<#93> just landed, conflicts
on StellarReceive, StellarSend, and WalletConnect:
git fetch origin
git rebase origin/develop# For all 3 files: keep develop's telemetry import and re-apply your asset-selector additions on top
git add -u
git rebase --continue
git push --force-with-lease
Also: I had unassigned you from #65
<#65> yesterday (when #79
<#79> closed) but feel free
to take it back since you're delivering on it now. I'll re-assign after
merge.
—
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=BFSYCOEJXKNSMIEABA4MHSL5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4826252510>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFSYCOF5CTJ2KG6GHWXP5RD5CEM7NAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMJQGEYDCNZXGM5US43TOVSTWNBXGYYTGNZZG42DTILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFSYCOHDH54GUUGXLSCS4VD5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BFSYCOCT27M2HCUEPGT7D6D5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
Hi, this is to remind you about the issues #65 i have fixed with you
reassigned to me. You said you would review and merge after I'm done.
kindly do so please
…On Sun, 28 Jun 2026 at 09:32, truthixify ***@***.***> wrote:
*truthixify* left a comment (wraith-protocol/demo#94)
<#94 (comment)>
Welcome back @DevScoopee <https://github.com/DevScoopee>! The new work
looks much better aligned with #65
<#65> (asset selector +
trustline-aware flows). After #93
<#93> just landed, conflicts
on StellarReceive, StellarSend, and WalletConnect:
git fetch origin
git rebase origin/develop# For all 3 files: keep develop's telemetry import and re-apply your asset-selector additions on top
git add -u
git rebase --continue
git push --force-with-lease
Also: I had unassigned you from #65
<#65> yesterday (when #79
<#79> closed) but feel free
to take it back since you're delivering on it now. I'll re-assign after
merge.
—
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=BFSYCOEJXKNSMIEABA4MHSL5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4826252510>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFSYCOF5CTJ2KG6GHWXP5RD5CEM7NAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMJQGEYDCNZXGM5US43TOVSTWNBXGYYTGNZZG42DTILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFSYCOHDH54GUUGXLSCS4VD5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BFSYCOCT27M2HCUEPGT7D6D5CEM7NA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBSGYZDKMRVGEYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@DevScoopee — heads up: this PR (#94) is closed. Your active PR for issue #65 is #96 (#96), which you opened right after. I checked #96 just now — the last push there is from June 29, and the rebase I asked for on June 29 (pnpm-lock.yaml + StellarReceive.tsx conflicts) still hasn't been done. Nothing has been merged because the PR doesn't merge cleanly yet. Please continue on #96 (not this one). See my updated ping over there. |
Contributor
Author
|
alright understood working on it right now
…On Thu, 2 Jul 2026 at 07:54, truthixify ***@***.***> wrote:
*truthixify* left a comment (wraith-protocol/demo#94)
<#94 (comment)>
@DevScoopee <https://github.com/DevScoopee> — heads up: this PR (#94
<#94>) is closed. Your active
PR for issue #65 <#65> is *#96
<#96>* (#96
<#96>), which you opened
right after.
I checked #96 <#96> just now
— the last push there is from June 29, and the rebase I asked for on June
29 (pnpm-lock.yaml + StellarReceive.tsx conflicts) still hasn't been done.
Nothing has been merged because the PR doesn't merge cleanly yet.
Please continue on #96 <#96>
(not this one). See my updated ping over there.
—
Reply to this email directly, view it on GitHub
<#94?email_source=notifications&email_token=BFSYCOFA4IKRBW7IZBDTTHL5CZENTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGUZTQNJZHA32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4865385987>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFSYCOFM4EFV6WXP5J27HTT5CZENTAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMJQGEYDCNZXGM5US43TOVSTWNBXGYYTGNZZG42DTILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BFSYCOESTDQJZCM5WD4LV5D5CZENTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGUZTQNJZHA32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BFSYCOEIO55DQEIX3XFPTXD5CZENTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGUZTQNJZHA32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added asset selector (XLM/USDC), trustline detection, per-asset balance display, and per-asset withdraw to Stellar Send and Receive flows, with 5 Playwright E2E tests for USDC.
Closes #65