Skip to content

fix(blocks): render CoreButton links without Link's legacyBehavior #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephfusco merged 2 commits into from
Nov 3, 2026
+25 −8
Merged

fix(blocks): render CoreButton links without Link's legacyBehavior #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4edcc6
fix(blocks): render CoreButton links without Link's legacyBehavior
josephfusco Nov 2, 2026
796d9d6
test(blocks): check CoreButton keeps its link attributes on one anchor
josephfusco Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/blocks/src/blocks/CoreButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,13 @@ export function CoreButton(props: CoreButtonFragmentProps) {
aria-label={attributes?.text}
id={attributes?.anchor}
className={attributes?.cssClassName}>
<Link legacyBehavior href={attributes?.url}>
<a
target={linkTarget}
className={attributes?.linkClassName}
rel={attributes?.rel}
style={style}>
<span>{attributes?.text}</span>
</a>
<Link
href={attributes.url}
target={linkTarget}
className={attributes?.linkClassName}
rel={attributes?.rel}
style={style}>
<span>{attributes?.text}</span>
</Link>
</div>
);
Expand Down
18 changes: 18 additions & 0 deletions packages/blocks/tests/blocks/CoreButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,24 @@ describe('<CoreButton />', () => {
);
});

test('puts the link attributes on a single anchor', () => {
const { container } = renderProvider({
attributes: {
text: 'Click',
url: '/about',
linkClassName: 'wp-block-button__link',
linkTarget: '_blank',
rel: 'noopener',
},
});
const link = screen.getByRole('link', { name: 'Click' });
expect(link).toHaveAttribute('href', '/about');
expect(link).toHaveAttribute('target', '_blank');
expect(link).toHaveAttribute('rel', 'noopener');
expect(link).toHaveClass('wp-block-button__link');
expect(container.querySelectorAll('a')).toHaveLength(1);
});

// WordPress 7.0+ stores text alignment in style.typography.textAlign and
// adds the has-text-align-* class to the saved markup.
test('keeps text alignment from WordPress 7.0+ through the class name', () => {
Expand Down
Loading