[Copilot]

This updates language-pack download temp-path handling to use the WP-CLI temp-file helper and avoid creating unused empty temp files on cache misses. The temp file is now created only when a cached artifact is actually copied.

• Download temp file lifecycle

  • Removed manual temp path construction (get_temp_dir() . uniqid(...)).
  • Moved temp file creation into the cache-hit branch.
  • Switched to \WP_CLI\Utils\make_temp_file( 'wp_', '.' . $ext ) before copy( $cache_file, $temp ).

• Behavioral coverage

  • Added a focused Behat core-language scenario to exercise reinstall-from-cache and assert the cached path is used (Using cached file ...).

if ( $cache_file ) {
	$temp = \WP_CLI\Utils\make_temp_file( 'wp_', '.' . $ext );
	WP_CLI::log( "Using cached file '$cache_file'..." );
	copy( $cache_file, $temp );
	return $temp;
}

• Fixes Use Utils\make_temp_file() for the download temp path #189

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e37e719a-2095-4bae-80d9-6f1fe35662cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

The changes are covered by focused tests and have no unresolved blocking issues.

Pull request overview

Updates language-pack downloads to create temporary files only when copying cached artifacts.

Changes:

• Replaces manual temp-path construction with make_temp_file().
• Adds Behat coverage for cached language installation.

File summaries

File	Description
src/WP_CLI/LanguagePackUpgrader.php	Defers temp-file creation to cache hits.
features/language-core.feature	Verifies cached language installation.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!