Skip to content

Fix PHPCS errors in Behat test files - #19

Merged
swissspidy merged 1 commit into
mainfrom
fix/tests-lint
Sep 1, 2026
Merged

swissspidy merged 1 commit into
mainfrom
fix/tests-lint

Conversation

@swissspidy

@swissspidy swissspidy commented Sep 1, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Reformatted block style registration examples for improved readability.
    • No changes to functionality or expected behavior.

Copilot AI lite review requested due to automatic review settings September 1, 2026 10:34
@swissspidy
swissspidy requested a review from a team as a code owner September 1, 2026 10:34
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: ff7545ed-c349-470a-82aa-c45f820a7e44

📥 Commits

Reviewing files that changed from the base of the PR and between 9579680 and 2f0c78c.

📒 Files selected for processing (1)
  • features/block-style.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change reformats two block style registration snippets in features/block-style.feature. The registered styles and test scenarios remain unchanged.

Changes

Block style fixtures

Layer / File(s) Summary
Reformat block style registrations
features/block-style.feature
The fancy-quote and format-test-style add_action calls now use multi-line formatting. Their hooks, callbacks, and registered styles remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 2f0c7

This PR only reformats test-fixture PHP code without changing the registered block styles or runtime behavior, so no actionable merge-blocking risk remains.

Suggested reviewers: brianhenryie

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the changes. The pull request reformats Behat test fixture code to address PHPCS errors without changing behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tests-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Behat acceptance test feature to resolve PHPCS/style issues by reformatting embedded PHP examples used to register block styles.

Changes:

  • Reformatted the add_action() + closure registration blocks to a multiline style.
  • Reformatted the nested register_block_style() call and array argument for readability/consistency.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@swissspidy swissspidy added this to the 1.0.3 milestone Sep 1, 2026
@swissspidy
swissspidy merged commit 309fa21 into main Sep 1, 2026
57 checks passed
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants