Repository navigation
Feature: Dockable debug output accessible in Debug menu - #227
Merged
Merged
Conversation
Options: autoscroll, copy-all, detail view, disable it from updating via advanced preference which is checkable in the logger widget
worldwideweary
force-pushed
the
feature/qDebugConsoleLog
branch
from
September 9, 2026 23:04
b161e57 to
17cb815
Compare
Workspace::addActionAndString() always appends
::findActionFromString() returns the first matching string.
This commit fixes:
old QAction* entry of "debug-log" in the static list.
The next MuseScore creates a new action and appends:
old dead QAction* → "debug-log"
new live QAction* → "debug-log"
Then:
findActionFromString("debug-log")
returns the old dead pointer, and:
menu->addAction(action) fails
Change this to ON and release builds will work with this.
worldwideweary
force-pushed
the
feature/qDebugConsoleLog
branch
from
September 9, 2026 23:32
17cb815 to
9a1d780
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can also be done with a release build, but for now I kept it debug only. There exists a commit that can be dropped here (the revert for the release build). I think personally it would be cool to have in release also, and I don't think it should have any performance hit since debug statement "usually" are only small portions. The problem is if there becomes a buffer problem or something that occurs multiple times a lot, and then it can degrade performance which you probably wouldn't want in a release build