Conversation
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy@hergault.fr>
oschijns
approved these changes
Apr 26, 2026
Contributor
oschijns
left a comment
There was a problem hiding this comment.
I cannot test it yet.
Overall looks fine, but the pipeline failed.
(Looks like an unrelated issue.)
Contributor
Author
|
For Windows we could include: #[cfg(target_os = "windows")]
if let Ok(output) = Command::new("reg")
.args(["query", r"HKLM\SOFTWARE\Microsoft\Cryptography", "/v", "MachineGuid"])
.output()
&& output.status.success()
&& let Ok(output_str) = String::from_utf8(output.stdout)
{
for line in output_str.lines() {
if line.contains("MachineGuid")
&& let Some(value) = line.split_whitespace().last()
&& let Ok(machine_uuid) = Uuid::parse_str(value.trim())
{
return machine_uuid.to_string();
}
}
}But the compilation is a mess, so don't need to include it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following tests on Grafana Cloud, metrics are not perfect regarding labels.
From service semantic conventions we should have
service.instance.id,service.namespace,service.name.This triplet MUST be globally unique, so this change add these missing labels to have a
jobandinstanceon Grafana Cloud metrics.