Skip to content

wallet: do not gate daemon calls on a cached connection check #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodser merged 2 commits into from
Aug 28, 2026
Merged

wallet: do not gate daemon calls on a cached connection check #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c24118e
wallet: do not gate daemon calls on a cached connection check
woodser Aug 28, 2026
78cd893
docs: update doxygen docs
woodser Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
266 changes: 143 additions & 123 deletions docs/doxygen/annotated.html
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/doxygen/classes.html
View file
Open in desktop

Large diffs are not rendered by default.

111 changes: 63 additions & 48 deletions docs/doxygen/classmonero_1_1monero__daemon-members.html
View file
Open in desktop

Large diffs are not rendered by default.

619 changes: 594 additions & 25 deletions docs/doxygen/classmonero_1_1monero__daemon.html
View file
Open in desktop

Large diffs are not rendered by default.

115 changes: 65 additions & 50 deletions docs/doxygen/classmonero_1_1monero__daemon__rpc-members.html
View file
Open in desktop

Large diffs are not rendered by default.

593 changes: 568 additions & 25 deletions docs/doxygen/classmonero_1_1monero__daemon__rpc.html
View file
Open in desktop

Large diffs are not rendered by default.

73 changes: 37 additions & 36 deletions docs/doxygen/classmonero_1_1monero__rpc__connection-members.html
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions docs/doxygen/classmonero_1_1monero__rpc__connection.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,12 @@
</table><table class="memberdecls">
<tr class="heading"><td colspan="2"><h2 class="groupheader"><a id="pub-static-methods" name="pub-static-methods"></a>
Static Public Member Functions</h2></td></tr>
<tr class="memitem:aea8117f9441594a77c0f9bcc266fb754" id="r_aea8117f9441594a77c0f9bcc266fb754"><td class="memItemLeft" align="right" valign="top"><a id="aea8117f9441594a77c0f9bcc266fb754" name="aea8117f9441594a77c0f9bcc266fb754"></a>
static std::shared_ptr&lt; <a class="el" href="classmonero_1_1monero__rpc__connection.html">monero_rpc_connection</a> &gt;&#160;</td><td class="memItemRight" valign="bottom"><b>from_property_tree</b> (const boost::property_tree::ptree &amp;node)</td></tr>
<tr class="separator:aea8117f9441594a77c0f9bcc266fb754"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a064a64620c73045ccb47e22088abebd0" id="r_a064a64620c73045ccb47e22088abebd0"><td class="memItemLeft" align="right" valign="top"><a id="a064a64620c73045ccb47e22088abebd0" name="a064a64620c73045ccb47e22088abebd0"></a>
static void&#160;</td><td class="memItemRight" valign="bottom"><b>from_property_tree</b> (const boost::property_tree::ptree &amp;node, const std::shared_ptr&lt; <a class="el" href="classmonero_1_1monero__rpc__connection.html">monero_rpc_connection</a> &gt; &amp;connection)</td></tr>
<tr class="separator:a064a64620c73045ccb47e22088abebd0"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a051afdc391dba6ffe81c7b7b5c54a61e" id="r_a051afdc391dba6ffe81c7b7b5c54a61e"><td class="memItemLeft" align="right" valign="top"><a id="a051afdc391dba6ffe81c7b7b5c54a61e" name="a051afdc391dba6ffe81c7b7b5c54a61e"></a>
static std::shared_ptr&lt; <a class="el" href="classmonero_1_1monero__rpc__connection.html">monero_rpc_connection</a> &gt;&#160;</td><td class="memItemRight" valign="bottom"><b>deserialize</b> (const std::string &amp;json)</td></tr>
<tr class="separator:a051afdc391dba6ffe81c7b7b5c54a61e"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:aaafd6f0884b9b0eb13abed7dd682eb49" id="r_aaafd6f0884b9b0eb13abed7dd682eb49"><td class="memItemLeft" align="right" valign="top">static bool&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="#aaafd6f0884b9b0eb13abed7dd682eb49">compare</a> (int p1, int p2)</td></tr>
<tr class="separator:aaafd6f0884b9b0eb13abed7dd682eb49"><td class="memSeparator" colspan="2">&#160;</td></tr>
</table><table class="memberdecls">
Expand Down
2 changes: 1 addition & 1 deletion docs/doxygen/classmonero_1_1monero__wallet.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3117,7 +3117,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#a55555b01d8beea85545ed807
</div><div class="memdoc">
<p>Check if the wallet is closed. </p>

<p>Reimplemented in <a class="el" href="classmonero_1_1monero__wallet__full.html#af276845716a876280a62cb92a489a292">monero::monero_wallet_full</a>, and <a class="el" href="classmonero_1_1monero__wallet__rpc.html#a56b7726bdae720e757987c1751e54454">monero::monero_wallet_rpc</a>.</p>
<p>Reimplemented in <a class="el" href="classmonero_1_1monero__wallet__full.html#af276845716a876280a62cb92a489a292">monero::monero_wallet_full</a>, <a class="el" href="classmonero_1_1monero__wallet__keys.html#a25a11475eeb08cdf163edf9ee612afae">monero::monero_wallet_keys</a>, and <a class="el" href="classmonero_1_1monero__wallet__rpc.html#a56b7726bdae720e757987c1751e54454">monero::monero_wallet_rpc</a>.</p>

</div>
</div>
Expand Down
20 changes: 10 additions & 10 deletions docs/doxygen/classmonero_1_1monero__wallet__keys-members.html
View file
Open in desktop

Large diffs are not rendered by default.

50 changes: 39 additions & 11 deletions docs/doxygen/classmonero_1_1monero__wallet__keys.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@
<tr class="separator:a423810896328a3c25a9ad36b52001a5b"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a2847e32abdcc6c9882297368d68c94c2" id="r_a2847e32abdcc6c9882297368d68c94c2"><td class="memItemLeft" align="right" valign="top">void&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="#a2847e32abdcc6c9882297368d68c94c2">close</a> (bool <a class="el" href="classmonero_1_1monero__wallet.html#a0160f23ebba72ab5be52e6509c918a5e">save</a>=false) override</td></tr>
<tr class="separator:a2847e32abdcc6c9882297368d68c94c2"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a25a11475eeb08cdf163edf9ee612afae" id="r_a25a11475eeb08cdf163edf9ee612afae"><td class="memItemLeft" align="right" valign="top">bool&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="#a25a11475eeb08cdf163edf9ee612afae">is_closed</a> () const override</td></tr>
<tr class="separator:a25a11475eeb08cdf163edf9ee612afae"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="inherit_header pub_methods_classmonero_1_1monero__wallet"><td colspan="2" onclick="javascript:dynsection.toggleInherit('pub_methods_classmonero_1_1monero__wallet')"><img src="closed.png" alt="-"/>&#160;Public Member Functions inherited from <a class="el" href="classmonero_1_1monero__wallet.html">monero::monero_wallet</a></td></tr>
<tr class="memitem:ac8a0a50f23cf2b6a611ca5ecc2a907ce inherit pub_methods_classmonero_1_1monero__wallet" id="r_ac8a0a50f23cf2b6a611ca5ecc2a907ce"><td class="memItemLeft" align="right" valign="top">virtual&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="classmonero_1_1monero__wallet.html#ac8a0a50f23cf2b6a611ca5ecc2a907ce">~monero_wallet</a> ()</td></tr>
<tr class="separator:ac8a0a50f23cf2b6a611ca5ecc2a907ce inherit pub_methods_classmonero_1_1monero__wallet"><td class="memSeparator" colspan="2">&#160;</td></tr>
Expand Down Expand Up @@ -366,8 +368,6 @@
<tr class="separator:a85c3484ccfea43aa624c3c8f1bd3ab8b inherit pub_methods_classmonero_1_1monero__wallet"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a0160f23ebba72ab5be52e6509c918a5e inherit pub_methods_classmonero_1_1monero__wallet" id="r_a0160f23ebba72ab5be52e6509c918a5e"><td class="memItemLeft" align="right" valign="top">virtual void&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="classmonero_1_1monero__wallet.html#a0160f23ebba72ab5be52e6509c918a5e">save</a> ()</td></tr>
<tr class="separator:a0160f23ebba72ab5be52e6509c918a5e inherit pub_methods_classmonero_1_1monero__wallet"><td class="memSeparator" colspan="2">&#160;</td></tr>
<tr class="memitem:a55555b01d8beea85545ed80737778048 inherit pub_methods_classmonero_1_1monero__wallet" id="r_a55555b01d8beea85545ed80737778048"><td class="memItemLeft" align="right" valign="top">virtual bool&#160;</td><td class="memItemRight" valign="bottom"><a class="el" href="classmonero_1_1monero__wallet.html#a55555b01d8beea85545ed80737778048">is_closed</a> () const</td></tr>
<tr class="separator:a55555b01d8beea85545ed80737778048 inherit pub_methods_classmonero_1_1monero__wallet"><td class="memSeparator" colspan="2">&#160;</td></tr>
</table><table class="memberdecls">
<tr class="heading"><td colspan="2"><h2 class="groupheader"><a id="pub-static-methods" name="pub-static-methods"></a>
Static Public Member Functions</h2></td></tr>
Expand Down Expand Up @@ -705,7 +705,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#af0d118734096a7faa1e4018d
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -734,7 +734,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#acca0795b9455f5f67dbdb4a8
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -763,7 +763,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#aeca6751dff2d1286878b0bff
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -792,7 +792,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#a1a256166f00fbb8487c52dc7
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -821,7 +821,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#aaa29dad0f3eddf8a325e3777
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -850,7 +850,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#ad3d14076b6b7c07e89924e9a
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -879,7 +879,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#acfa833fcc9b5369fcba5f8ee
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -908,7 +908,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#a890195401d087b65a1e8aba6
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down Expand Up @@ -1013,6 +1013,34 @@ <h2 class="memtitle"><span class="permalink"><a href="#a408e2f71d80854ba59f49207

<p>Reimplemented from <a class="el" href="classmonero_1_1monero__wallet.html#a6b69f718345c5425264b0de9b89b6a27">monero::monero_wallet</a>.</p>

</div>
</div>
<a id="a25a11475eeb08cdf163edf9ee612afae" name="a25a11475eeb08cdf163edf9ee612afae"></a>
<h2 class="memtitle"><span class="permalink"><a href="#a25a11475eeb08cdf163edf9ee612afae">&#9670;&#160;</a></span>is_closed()</h2>

<div class="memitem">
<div class="memproto">
<table class="mlabels">
<tr>
<td class="mlabels-left">
<table class="memname">
<tr>
<td class="memname">bool monero::monero_wallet_keys::is_closed </td>
<td>(</td>
<td class="paramname"><span class="paramname"><em></em></span></td><td>)</td>
<td> const</td>
</tr>
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
<p>Check if the wallet is closed. </p>

<p>Reimplemented from <a class="el" href="classmonero_1_1monero__wallet.html#a55555b01d8beea85545ed80737778048">monero::monero_wallet</a>.</p>

</div>
</div>
<a id="a534e10f6fa13d8da262e81c581355937" name="a534e10f6fa13d8da262e81c581355937"></a>
Expand All @@ -1033,7 +1061,7 @@ <h2 class="memtitle"><span class="permalink"><a href="#a534e10f6fa13d8da262e81c5
</table>
</td>
<td class="mlabels-right">
<span class="mlabels"><span class="mlabel inline">inline</span><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
<span class="mlabels"><span class="mlabel override">override</span><span class="mlabel virtual">virtual</span></span> </td>
</tr>
</table>
</div><div class="memdoc">
Expand Down
Loading
Loading