data model: implement missing from property tree - #157
Merged
woodser merged 1 commit intoAug 27, 2026
Merged
Conversation
* Implement ssl_options::from_property_tree * Implement monero_block_header::from_property_tree * Implement monero_block::from_property_tree * Implement monero_wallet_config::from_property_tree and refactory monero_wallet_config::deserialize * Implement monero_sync_result::from_property_tree * Implement monero_incoming_transfer::from_property_tree * Implement monero_outgoing_transfer::from_property_tree * Implement monero_tx_config::from_property_tree and refactory monero_tx_config::deserialize * Implement monero_key_image_export_result::from_property_tree and refactory monero_key_image_export_result::deserialize * Implement monero_check::from_property_tree * Implement monero_decoded_address::from_property_tree
everoddandeven
force-pushed
the
data-model/implement-missing-from-property-tree
branch
from
August 27, 2026 17:57
9ac4d5f to
3841df1
Compare
everoddandeven
changed the title
everoddandeven
deleted the
data-model/implement-missing-from-property-tree
branch
August 27, 2026 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful to test the serialization/deserialization of these missing structures in the unit tests I implemented in monero-python for monero-cpp's data model bindings. I actually use this template function in bindings to expose
deserializemethod for data model from JSON string. Wondering if that template function should be part of monero-cpp and use that for exposedeserializemethods for all public data structure withfrom_property_tree.