Repository navigation
Conversation
|
dgarske
force-pushed
the
rtl8735b_ecb_wrap
branch
from
November 6, 2026 23:20
5a95202 to
46d016e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RTL8735B HUK ECDSA sign path (
wc_Rtl8735b_EccKeyviaecc_key->devCtx) only accepted an AES-GCM-wrapped scalar, so a blob wrapped with AES-ECB under the HUK, the layout STM32 DHUK uses forwc_ecc_import_wrapped_private(), could not be signed with. It now treats a key withiv,ivSz,tagandtagSzall NULL/0 as ECB-wrapped (block-padded, scalar in the firstplainLenbytes), rejects a partial IV/tag set, and leaves GCM unchanged and recommended.Testing
Tested on an RTL8735B EVB with both formats, with host self-test cases for the format checks.
Checklist