[dgarske]

Description

AES-XTS is AES-ECB over tweak-masked data, and _AesXtsHelper() already issues one bulk ECB call per XTS call through the crypto callback, so the Athena F5200 port needs an ECB case and no XTS code. Validating it on the MPFS250TS Video Kit also turned up two bugs that this fixes.

• mpfs_athena.c: WC_CIPHER_AES_ECB for AES-256, both directions. WC_MPFS_ATHENA_AES_MIN_SZ (32) declines shorter requests to software: XTS sends its tweak and ciphertext-stealing tail as one-block wc_AesEncryptDirect() requests, and one engine round trip per block loses to software. The self-test covers distinct and in-place buffers, the shape XTS uses.
• CTR counter carry: the engine increments only the low 32 bits of the counter block, so any stream crossing that boundary diverged from wc_AesCtrEncrypt(). Each transfer now stops at the wrap and aes->reg is advanced in software; the self-test runs a stream across it.
• aes.c: the 64-bit GMULT() table path reads at odd offsets and had no WOLFSSL_USE_ALIGN guard, unlike the 32-bit path; a strict-alignment 64-bit target now takes the byte loop, and the unreachable copy of it is removed.
• configure.ac turns on AES-ECB with --with-mpfs-athena --enable-aesxts; CI legs for ECB alone and the XTS build; README.

AES-128 and AES-192 requests stay in software, as before.

Testing

MPFS250TS Video Kit, E51 bare metal under wolfBoot's test-app: the self-test, the full wolfcrypt_test() (AES-XTS through the engine, the AES-CTR wrap vector that failed before, AES-GCM where it trapped before) and the benchmark. Host: make check with --enable-aesxts --enable-aesecb --enable-cryptocb, testwolfcrypt with and without WOLFSSL_USE_ALIGN, every port CI leg compiled.

[github-actions]

MemBrowse Memory Report · Explore what changed →

zephyr-frdm_rw612

• FLASH: log_const_area -8 B, rodata -8 B, text +1,664 B (+0.6%, 284,112 B / 67,108,864 B, total: 0% used)

No memory changes detected for:

• gcc-arm-cortex-m0plus
• gcc-arm-cortex-m3
• gcc-arm-cortex-m4
• gcc-arm-cortex-m4-baremetal
• gcc-arm-cortex-m4-crypto-only
• gcc-arm-cortex-m4-dtls13
• gcc-arm-cortex-m4-min-ecc
• gcc-arm-cortex-m4-openssl-compat
• gcc-arm-cortex-m4-pkcs7
• gcc-arm-cortex-m4-pq
• gcc-arm-cortex-m4-rsa-only
• gcc-arm-cortex-m4-sp-math
• gcc-arm-cortex-m4-tls12
• gcc-arm-cortex-m4-tls13
• gcc-arm-cortex-m7
• gcc-arm-cortex-m7-pq
• gcc-arm-cortex-m7-tls13
• stm32-sim-stm32h753

---

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #12055

Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .github/workflows/mpfs-athena-compile.yml, configure.ac, wolfcrypt/src/port/microchip/README.md
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Max