Skip to content

Fix undefined behavior in C SP math and sp_int under non -fwrapv, and a dropped carry in the ARM32/Thumb2 SP squares #12053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgarske wants to merge 5 commits into
base: master
Choose a base branch
from
+730 −605
Open

Fix undefined behavior in C SP math and sp_int under non -fwrapv, and a dropped carry in the ARM32/Thumb2 SP squares #12053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b0778d
wolfcrypt: avoid signed overflow in ML-DSA and C SP arithmetic
armpribb Oct 9, 2026
eef486f
test: respect digest limits in P-256 SP regression
armpribb Oct 19, 2026
a9d8180
SP C: regenerate with unsigned limb packing, subtraction and bit coun…
dgarske Nov 5, 2026
04a69d1
Check the output buffer before offsetting it in sp_to_unsigned_bin_at…
dgarske Nov 6, 2026
ea7f744
SP ARM32 and Thumb2: keep the carry of the first doubled product in e…
dgarske Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions wolfcrypt/src/sp_arm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26025,7 +26025,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
"str r3, [sp, #4]\n\t"
Expand Down Expand Up @@ -26081,7 +26080,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[1] * A[1] */
Expand Down Expand Up @@ -26165,7 +26163,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[1] * A[2] */
Expand Down Expand Up @@ -26273,7 +26270,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[1] * A[3] */
Expand Down Expand Up @@ -28634,7 +28630,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[8] * A[10] */
Expand Down Expand Up @@ -28770,7 +28765,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[9] * A[10] */
Expand Down Expand Up @@ -28878,7 +28872,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[10] * A[10] */
Expand Down Expand Up @@ -28962,7 +28955,6 @@ WC_OMIT_FRAME_POINTER static void sp_3072_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
"str r2, [%[r], #84]\n\t"
Expand Down Expand Up @@ -88916,7 +88908,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
"str r3, [sp, #4]\n\t"
Expand Down Expand Up @@ -88972,7 +88963,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[1] * A[1] */
Expand Down Expand Up @@ -89056,7 +89046,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[1] * A[2] */
Expand Down Expand Up @@ -89164,7 +89153,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[1] * A[3] */
Expand Down Expand Up @@ -91525,7 +91513,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[8] * A[10] */
Expand Down Expand Up @@ -91661,7 +91648,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[9] * A[10] */
Expand Down Expand Up @@ -91769,7 +91755,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[10] * A[10] */
Expand Down Expand Up @@ -91853,7 +91838,6 @@ WC_OMIT_FRAME_POINTER static void sp_384_sqr_12(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
"str r2, [%[r], #84]\n\t"
Expand Down Expand Up @@ -113655,7 +113639,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
"str r3, [sp, #4]\n\t"
Expand Down Expand Up @@ -113711,7 +113694,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[1] * A[1] */
Expand Down Expand Up @@ -113795,7 +113777,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[1] * A[2] */
Expand Down Expand Up @@ -113903,7 +113884,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[1] * A[3] */
Expand Down Expand Up @@ -119069,7 +119049,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[13] * A[15] */
Expand Down Expand Up @@ -119205,7 +119184,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[14] * A[15] */
Expand Down Expand Up @@ -119313,7 +119291,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[15] * A[15] */
Expand Down Expand Up @@ -119397,7 +119374,6 @@ WC_OMIT_FRAME_POINTER static void sp_521_sqr_17(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
"str r3, [%[r], #124]\n\t"
Expand Down Expand Up @@ -141751,7 +141727,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
"str r3, [sp, #4]\n\t"
Expand Down Expand Up @@ -141807,7 +141782,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[1] * A[1] */
Expand Down Expand Up @@ -141891,7 +141865,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[1] * A[2] */
Expand Down Expand Up @@ -141999,7 +141972,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[1] * A[3] */
Expand Down Expand Up @@ -146528,7 +146500,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
/* A[12] * A[14] */
Expand Down Expand Up @@ -146664,7 +146635,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r4, r4, #0\n\t"
"adds r2, r2, r8\n\t"
"adcs r3, r3, r9\n\t"
"mov r4, #0\n\t"
"adc r4, r4, #0\n\t"
#endif
/* A[13] * A[14] */
Expand Down Expand Up @@ -146772,7 +146742,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r2, r2, #0\n\t"
"adds r3, r3, r8\n\t"
"adcs r4, r4, r9\n\t"
"mov r2, #0\n\t"
"adc r2, r2, #0\n\t"
#endif
/* A[14] * A[14] */
Expand Down Expand Up @@ -146856,7 +146825,6 @@ WC_OMIT_FRAME_POINTER static void sp_1024_sqr_16(sp_digit* r, const sp_digit* a)
"adc r3, r3, #0\n\t"
"adds r4, r4, r8\n\t"
"adcs r2, r2, r9\n\t"
"mov r3, #0\n\t"
"adc r3, r3, #0\n\t"
#endif
"str r4, [%[r], #116]\n\t"
Expand Down
Loading
Loading