Repository navigation
20261106-tests-null-deref-fixes - #12051
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The test continues after context setup fails and can dereference a NULL certificate manager in allocators that evaluate the heap argument.
1 open issue
What changed in this PR
This PR addresses null dereferences detected by cross-mingw-all-crypto in wolfSSL’s API decision-coverage tests.
Changes:
- Guard certificate-manager access with
EXPECT_SUCCESS(). - Guard TLS context field writes after setup expectations.
| File | Description |
|---|---|
tests/api/test_tls.c |
Guards server-hint and method-side writes in SetSSL_CTX coverage tests. |
tests/api/test_certman.c |
Guards access to ctx->cm after context creation. |
Review effort: Balanced
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12051
Scan targets checked: wolfssl-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Max
… test_certman_decision_coverage() and test_internal_SetSSL_CTX_DecisionCoverage().
1368c06 to
7671121
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12051
Scan targets checked: wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.

tests/api/test_certman.candtests/api/test_tls.c: fix null derefs intest_certman_decision_coverage()andtest_internal_SetSSL_CTX_DecisionCoverage().detected by
cross-mingw-all-cryptotested with