Skip to content

20261106-tests-null-deref-fixes - #12051

Merged
philljj merged 2 commits into
wolfSSL:masterfrom
douzzer:20261106-tests-null-deref-fixes
Nov 6, 2026
Merged

philljj merged 2 commits into
wolfSSL:masterfrom
douzzer:20261106-tests-null-deref-fixes

Conversation

@douzzer

@douzzer douzzer commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

tests/api/test_certman.c and tests/api/test_tls.c: fix null derefs in test_certman_decision_coverage() and test_internal_SetSSL_CTX_DecisionCoverage().

detected by cross-mingw-all-crypto

tested with

wolfssl-multi-test.sh ...
super-quick-check

@douzzer
douzzer requested a review from wolfSSL-Bot November 6, 2026 20:18
Copilot AI balanced review requested due to automatic review settings November 6, 2026 20:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test continues after context setup fails and can dereference a NULL certificate manager in allocators that evaluate the heap argument.

1 open issue
What changed in this PR

This PR addresses null dereferences detected by cross-mingw-all-crypto in wolfSSL’s API decision-coverage tests.

Changes:

  • Guard certificate-manager access with EXPECT_SUCCESS().
  • Guard TLS context field writes after setup expectations.
File Description
tests/​api/​test_tls.c Guards server-hint and method-side writes in SetSSL_CTX coverage tests.
tests/​api/​test_certman.c Guards access to ctx->cm after context creation.

Review effort: Balanced

Comment thread tests/api/test_certman.c Resolved
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

@philljj philljj self-assigned this Nov 6, 2026
@philljj
philljj requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Bot November 6, 2026 20:44
Comment thread tests/api/test_certman.c Resolved

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #12051

Scan targets checked: wolfssl-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Max

Comment thread tests/api/test_certman.c Resolved
@philljj philljj assigned douzzer and unassigned wolfSSL-Bot Nov 6, 2026
… test_certman_decision_coverage() and test_internal_SetSSL_CTX_DecisionCoverage().
@douzzer
douzzer force-pushed the 20261106-tests-null-deref-fixes branch from 1368c06 to 7671121 Compare November 6, 2026 22:38
@douzzer
douzzer requested review from wolfSSL-Fenrir-bot and a balanced review from Copilot November 6, 2026 22:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the pointer-access guards and known-macro list cleanup.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@douzzer douzzer assigned wolfSSL-Bot and unassigned douzzer Nov 6, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #12051

Scan targets checked: wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot dismissed their stale review November 6, 2026 23:02

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

@philljj philljj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks douzzer!

@philljj
philljj merged commit 0ac786e into wolfSSL:master Nov 6, 2026
418 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants