Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Arm toolchain installation and job timeout updates.
No open issues 🎉
What changed in this PR
Updates the AES Arm assembly CI workflow to install the Arm toolchain from the GHCR bundle, avoiding slow apt downloads and matching the existing Nuvoton workflow.
Changes:
- Uses
install-apt-depswith theubuntu-24.04-embeddedbundle forgcc-arm-none-eabi. - Raises the job timeout from 15 to 20 minutes to accommodate the bundle pull and retry budget.
| File | Description |
|---|---|
.github/workflows/aes-armasm-touch-lines.yml |
Switches toolchain installation to the shared bundle action and increases the timeout. |
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #12049
Scan targets checked: wolfssl-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
|
Description
The gcc-arm-none-eabi apt download (~574 MB) was exceeding the 15-minute timeout on slow runners; install it from the ubuntu-24.04-embedded ghcr bundle instead, matching nuvoton-m2354-compile.yml. Timeout raised to 20 minutes to fit the ~16-minute pull + retry budget of install-apt-deps.
Checklist