Skip to content

CI: install the Arm toolchain from the ghcr bundle in aes-touch-lines - #12049

Open
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:fix/ci-aes-touch-lines-apt
Open

stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:fix/ci-aes-touch-lines-apt

Conversation

@stenslae

@stenslae stenslae commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description

The gcc-arm-none-eabi apt download (~574 MB) was exceeding the 15-minute timeout on slow runners; install it from the ubuntu-24.04-embedded ghcr bundle instead, matching nuvoton-m2354-compile.yml. Timeout raised to 20 minutes to fit the ~16-minute pull + retry budget of install-apt-deps.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@stenslae stenslae self-assigned this Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 19:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Arm toolchain installation and job timeout updates.

No open issues 🎉

What changed in this PR

Updates the AES Arm assembly CI workflow to install the Arm toolchain from the GHCR bundle, avoiding slow apt downloads and matching the existing Nuvoton workflow.

Changes:

  • Uses install-apt-deps with the ubuntu-24.04-embedded bundle for gcc-arm-none-eabi.
  • Raises the job timeout from 15 to 20 minutes to accommodate the bundle pull and retry budget.
File Description
.github/​workflows/​aes-armasm-touch-lines.yml Switches toolchain installation to the shared bundle action and increases the timeout.

Review effort: Balanced

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #12049

Scan targets checked: wolfssl-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Max

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

@stenslae stenslae assigned wolfSSL-Bot and unassigned stenslae Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants