Repository navigation
error on dtls with ech - #12047
Open
sebastian-carpenter wants to merge 1 commit into
Open
error on dtls with ech#12047sebastian-carpenter wants to merge 1 commit into
sebastian-carpenter wants to merge 1 commit into
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The supplied review status reports no active issues, supporting approval of the change.
No open issues 🎉
What changed in this PR
This pull request prevents unsupported Encrypted Client Hello (ECH) use over DTLS and adds regression tests for DTLS 1.2 and 1.3 behavior.
Changes:
- Rejects client-side ECH configuration during DTLS extension population.
- Rejects server-side ECH configuration during generic and TLS 1.3 accept paths.
- Adds memory-I/O tests for ECH rejection and ECH-disabled handshakes.
| File | Summary |
|---|---|
tests/api.c |
Adds DTLS ECH rejection and ECH-disabled handshake coverage. |
src/tls13.c |
Rejects ECH-configured DTLS connections in the TLS 1.3 server path. |
src/tls.c |
Contains a moderate issue: the client-side guard should use WOLFSSL_DTLS rather than WOLFSSL_DTLS13 so DTLS 1.2 builds also reject configured ECH before sending data. |
src/ssl_api_hs.c |
Rejects ECH-configured DTLS connections in the generic server accept path. |
This pull request requires changes.
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The DTLS13 code does not currently support Encrypted Client Hello (ECH). Error instead of attempting to make a connection.
Connections would fail regardless for both the server and client. This just prevents it from being attempted.
The client will error when TLSX_PopulateExtensions() runs.
The server will error at wolfSSL_accept() or wolfSSL_accept_TLSv13().
Addresses GH #12013
Testing
Checklist