Repository navigation
wc_port: keep WC_OMIT_FRAME_POINTER gcc-only - #12043
Merged
Merged
Conversation
clang defines __GNUC__ but does not support the optimize() attribute with -f flags (only O-levels), so the macro emitted 'unknown attribute optimize ignored' and broke -Werror clang builds of files using it (e.g. sp_arm32.c). Under clang the macro now expands to empty.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change excluding Clang from the frame-pointer optimization attribute guard.
No open issues 🎉
What changed in this PR
This PR prevents Clang builds from receiving the unsupported optimize attribute through wolfSSL’s WC_OMIT_FRAME_POINTER macro, avoiding attribute warnings that can fail builds using -Werror.
Changes:
- Excludes Clang from the GNU compiler guard while preserving GCC behavior.
- Makes
WC_OMIT_FRAME_POINTERexpand to empty under Clang unless explicitly overridden.
| File | Description |
|---|---|
wolfssl/wolfcrypt/wc_port.h |
Adds a Clang exclusion to the frame-pointer optimization attribute guard. |
Review effort: Balanced
|
philljj
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang defines
__GNUC__, but does not support the optimize() attribute with -f flags (only O-levels), so the macro emitted 'unknown attribute optimize ignored' and broke -Werror clang builds of files using it (e.g. sp_arm32.c). Under clang the macro now expands to empty.