Repository navigation
linuxkm, .wolfssl_known_macro_extras: fix check-source-text failures - #12032
Merged
Merged
Conversation
- lkcapi_ecdsa_glue.c compares PTR_ERR(tfm) against -WC_NO_ERR_TRACE(ELIBBAD) in place of a bare -ELIBBAD. - .wolfssl_known_macro_extras drops WOLFSSL_DYNAMIC_PEER_CERT and WOLFSSL_FIPS_EXPORT_LOCAL_APIS, both defined in settings.h.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the error-code tracing and redundant macro cleanup.
No open issues 🎉
What changed in this PR
Fixes check-source-text failures and warnings in wolfSSL’s Linux kernel integration and macro bookkeeping, with no intended functional change.
Changes:
- Wraps
ELIBBADwithWC_NO_ERR_TRACEin the ECDSA driver check. - Removes two redundant macro entries already defined in
settings.h.
| File | Description |
|---|---|
linuxkm/lkcapi_ecdsa_glue.c |
Escapes the ELIBBAD comparison to satisfy error-code tracing checks. |
.wolfssl_known_macro_extras |
Removes redundant WOLFSSL_DYNAMIC_PEER_CERT and WOLFSSL_FIPS_EXPORT_LOCAL_APIS entries. |
Review effort: Balanced
|
yosuke-wolfssl
assigned
wolfSSL-Bot and
yosuke-wolfssl and unassigned
yosuke-wolfssl and
wolfSSL-Bot
1 of 4 tasks
Frauschi
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PRB
check-source-textfails on every PR based on current master.linuxkm/lkcapi_ecdsa_glue.c:1333comparesPTR_ERR(tfm)against a bare-ELIBBAD.ELIBBADis one of the errno codes traced inlinuxkm/module_hooks.c, so the "unescaped error code operands" subtest rejects it (fail_I)..wolfssl_known_macro_extraslistsWOLFSSL_DYNAMIC_PEER_CERTandWOLFSSL_FIPS_EXPORT_LOCAL_APIS. Both are now#defined inwolfssl/wolfcrypt/settings.h, so the check flags these entries as unneeded. This is a warning, not a failure.Fix (
linuxkm/lkcapi_ecdsa_glue.c)-WC_NO_ERR_TRACE(ELIBBAD)replaces the bare-ELIBBAD..wolfssl_known_macro_extrasdrops the two redundant entries.No functional change.
Verification
check-source-textscenario with the PRB configure line (--enable-all --enable-dtls13 --enable-quic --with-sys-crypto-policy ...):2b0874883cfail_Iatlkcapi_ecdsa_glue.c:1333, plus the two unneeded-extras warningscheck-source-text OK, no warnings; codespell clean.github/scripts/check-source-text.shclean on both changed files.