Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the output-length truncation fix.
No open issues 🎉
What changed in this PR
This PR prevents wolfSSL_FIPS_drbg_generate() from reporting unintended success when a large size_t output length truncates to zero during conversion to word32.
Changes:
- Reject output lengths that exceed the maximum
word32value before casting. - Add a regression test for a length of 2³² on platforms with wider
size_t, checking failure and an unchanged output buffer.
| File | Description |
|---|---|
tests/api.c |
Adds regression coverage for output-length truncation. |
src/ssl.c |
Checks the output-length bound before conversion to word32. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On a 64-bit build, an
outlenof exactly 2^32 is treated as 0. Add bounds check before(word32)outlencast inwolfSSL_FIPS_drbg_generate()to prevent unintentional success.Fixes F-10635
Testing
./configure --enable-opensslall && make && ./tests/unit.test -1814Checklist