Repository navigation
F-13114 adjustment to AES-CBC autosar output length - #11995
JacobBarthelmeh wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Successful START/FINISH-only calls leave output lengths unchanged despite producing no bytes, risking stale-buffer consumption, and the README contradicts the new length-handling contract.
2 open issues
What changed in this PR
This PR updates wolfCrypt’s AUTOSAR AES-CBC services to treat output length as an input capacity and return the number of bytes produced.
Changes:
- Validate output buffers and length pointers, rejecting insufficient capacity.
- Report the output length after successful CBC processing.
- Update tests to supply buffer capacities and check returned lengths and invalid inputs.
| File | Description |
|---|---|
wolfcrypt/src/port/autosar/test.c |
Supplies output capacities and adds length and error assertions. |
wolfcrypt/src/port/autosar/crypto.c |
Validates CBC output capacity, reports produced length, and updates a CMAC comment. |
Review effort: Balanced
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11995
Scan targets checked: wolfcrypt-port-bugs
Not reviewed (no scan target covers them): wolfcrypt/src/port/autosar/README.md
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: wolfcrypt/src/port/autosar/test.c
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11995
Scan targets checked: wolfcrypt-port-bugs
Not reviewed (no scan target covers them): wolfcrypt/src/port/autosar/README.md
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
df2c1aa to
80f299e
Compare


F-13114