Skip to content

sanity checks on truncation of input lengths - #11945

Open
JacobBarthelmeh wants to merge 5 commits into
wolfSSL:masterfrom
JacobBarthelmeh:fenrir
Open

JacobBarthelmeh wants to merge 5 commits into
wolfSSL:masterfrom
JacobBarthelmeh:fenrir

Conversation

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor

F-16878

@JacobBarthelmeh JacobBarthelmeh self-assigned this Oct 30, 2026
Copilot AI balanced review requested due to automatic review settings October 30, 2026 16:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report · Explore what changed →

gcc-arm-cortex-m0plus

  • FLASH: .text +40 B (+0.1%, 70,719 B / 262,144 B, total: 27% used)

gcc-arm-cortex-m3

  • FLASH: .text +252 B (+0.2%, 131,677 B / 262,144 B, total: 50% used)

gcc-arm-cortex-m4

  • FLASH: .text +412 B (+0.2%, 208,972 B / 262,144 B, total: 80% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +128 B (+0.2%, 73,463 B / 262,144 B, total: 28% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .text +576 B (+0.3%, 195,928 B / 1,048,576 B, total: 19% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +2,472 B, .text +960 B (+0.4%, 800,676 B / 1,048,576 B, total: 76% used)
  • RAM: .bss -12,048 B (-9.0%, 121,772 B / 262,144 B, total: 46% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .text -64 B (-0.0%, 222,740 B / 262,144 B, total: 85% used)

gcc-arm-cortex-m4-pq

  • FLASH: .text +832 B (+0.3%, 312,784 B / 1,048,576 B, total: 30% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +8 B, .text +1,024 B (+0.3%, 343,632 B / 1,048,576 B, total: 33% used)
  • RAM: .bss +1,320 B (+7.9%, 17,996 B / 262,144 B, total: 7% used)

gcc-arm-cortex-m4-tls12

  • FLASH: .text +256 B (+0.2%, 132,433 B / 262,144 B, total: 51% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .text +640 B (+0.3%, 249,506 B / 262,144 B, total: 95% used)

gcc-arm-cortex-m7

  • FLASH: .text +348 B (+0.2%, 208,972 B / 262,144 B, total: 80% used)

gcc-arm-cortex-m7-pq

  • FLASH: .text +768 B (+0.2%, 313,616 B / 1,048,576 B, total: 30% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .text +576 B (+0.2%, 249,506 B / 262,144 B, total: 95% used)

stm32-sim-stm32h753

  • FLASH: .text -832 B (-0.4%, 203,756 B / 2,097,152 B, total: 10% used)

zephyr-frdm_rw612

  • FLASH: text +32 B (+0.0%, 284,040 B / 67,108,864 B, total: 0% used)

No memory changes detected for:


Catch memory regressions in CI with MemBrowse. Free for open source.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #11945

Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 3 of 4 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_ossl_mac.c

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

Comment thread tests/api/test_ossl_dgst.c Resolved

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #11945

Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot dismissed their stale review November 3, 2026 22:33

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins

Comment thread src/ssl_crypto.c

/* wolfCrypt takes a word32 length - fail rather than truncate. */
if (!WOLFSSL_CRYPTO_LEN_FITS_WORD32(sz)) {
return 0;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add WOLFSSL_MSG calls to all of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants