Repository navigation
sbom: vendor wolfssl-compliance-tooling for make and CMake #11701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sameehj
wants to merge
10
commits into
wolfSSL:master
Choose a base branch
from
sameehj:feat/sbom-compliance-tooling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
45386ae
sbom: vendor wolfssl-compliance-tooling for make and CMake
sameehj f40cc52
sbom: accept the stable package URL and keep the old entry points.
sameehj 1d52ff3
sbom: track the vendored CMake and plain-Make fragments.
sameehj 86e4a98
sbom: use this tree for CMake inputs and the new driver pin
sameehj 73e43d7
sbom: skip the CMake target in a subproject and pin toolkit 37
sameehj 1b5a7e8
sbom: pin the toolkit snapshot to current master
sameehj 86cd580
Sort .wolfssl_known_macro_extras in C lexical order
sameehj 5bd3e93
sbom: vendor the toolkit sbom.mk without hard tabs
sameehj 71c8a75
sbom: pin the toolkit sbom.mk with the SBOM_TAB guard
sameehj 2d0fc17
sbom: let the toolkit CMake helper stage and validate, fix review items
sameehj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No job builds the CMake
sbomorinstall-sbomtargets, which is how the problems above got through. Could you add one, plus a drift check oftools/sbom/against the pin (wolfssl-compliance-tooling-sync --check, or the toolkit'ssbom-reusable.yml)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 2d0fc17. The new
cmakejob configures with an absoluteCMAKE_INSTALL_LIBDIR, builds, and runsinstall-sbomalone underDESTDIR. It checks the three installed files, that nothing goes to the absolute directory, that no_sbom_stagingstays, the library hash againstcmake --install, the CycloneDX schema,uninstall-sbom, and that-DCMAKE_DISABLE_FIND_PACKAGE_Python3=ONconfigures and fails only thesbomtarget. The newdriftjob clones the toolkit at the pinned revision and runswolfssl-compliance-tooling-sync --check.