MC/DC: coverage campaign part 9 by danielinux · Pull Request #11595 · wolfSSL/wolfssl

danielinux · 2026-09-29T20:03:55Z

New decision-coverage drivers for the conditions upstream added since the part-8 anchor:

random.c (test_wc_DrbgReworkDecisionCoverage): the per-width Present/GetReseedCtr/ScheduleReseed arms driven through both DRBG widths with the type/pointer pairings poked on live instances, the Reseed_Nonce/Stir_Nonce NULL pairs, the InitRngNonce_ex2 perso clause tails, and the USE_FULL_MUTEX/NO_AUTO_LOCK init-flag arms. The SHA-512 DRBG is re-enabled after the SHA-256-width section so the process-wide DRBG state is restored.

aes.c (test_wc_AesReworkDecisionCoverage): the XTS unset-key guard (all four keylen/rounds rows), the GcmInit clause tail through wc_AesGcmEncryptInit (stream builds), the GcmSetIV clause tails (valid fixed part, oversized fixed part, NULL rng, NULL ivFixed, invalid size), the CTR leftover-keystream loop with left drained to zero, and the CFB two-block decrypt drain.

test_ssl_ext.c (test_wolfSSL_EnableRequireExtendedMasterSecret_ext): NULL pairs for the six EMS enable/require APIs, the client/server/ side-less/TLS-1.3 method branches of the re-arm checks, and the connect/accept handshake-state guard rows.

more test coverage

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-30T01:42:34Z

MemBrowse Memory Report · Explore what changed →

gcc-arm-cortex-m3

FLASH: .text +36 B (+0.0%, 131,673 B / 262,144 B, total: 50% used)

gcc-arm-cortex-m4-baremetal

FLASH: .text +64 B (+0.1%, 73,463 B / 262,144 B, total: 28% used)

gcc-arm-cortex-m4-crypto-only

FLASH: .text +64 B (+0.0%, 181,651 B / 262,144 B, total: 69% used)

gcc-arm-cortex-m4-dtls13

FLASH: .text +64 B (+0.0%, 195,800 B / 1,048,576 B, total: 19% used)

gcc-arm-cortex-m4-openssl-compat

FLASH: .text -768 B (-0.1%, 800,548 B / 1,048,576 B, total: 76% used)

gcc-arm-cortex-m4-pq

FLASH: .text +64 B (+0.0%, 312,656 B / 1,048,576 B, total: 30% used)

gcc-arm-cortex-m4-tls13

FLASH: .text +64 B (+0.0%, 249,378 B / 262,144 B, total: 95% used)

gcc-arm-cortex-m7

FLASH: .text +64 B (+0.0%, 208,972 B / 262,144 B, total: 80% used)

No memory changes detected for:

_{Catch memory regressions in CI with MemBrowse. Free for open source.}

danielinux · 2026-11-04T00:07:22Z

jenkins retest this please

danielinux · 2026-11-04T14:11:39Z

jenkins retest this please

danielinux · 2026-11-04T15:20:01Z

jenkins retest this please
[failure in the post-test stage]

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11595

Scan targets checked: wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, tests/api/check-api-guards.py, tests/api/test_aes.h, tests/api/test_asn.h, tests/api/test_certman.h, tests/api/test_dh.h, tests/api/test_kdf.h, tests/api/test_mldsa.h, tests/api/test_pkcs7.h, tests/api/test_random.h, tests/api/test_session.h, tests/api/test_ssl_cert.h, tests/api/test_ssl_crl_ocsp.h, tests/api/test_ssl_ext.h, tests/api/test_tls.h, tests/api/test_tls13.h, tests/api/test_x509.h, tests/include.am, tests/unit-mcdc/mcdc_der_edit.h, tests/unit-mcdc/mcdc_fault_alloc.h and 3 more
Coverage: 6 of 44 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_aes.c, tests/api/test_asn.c, tests/api/test_certman.c, tests/api/test_dh.c, tests/api/test_kdf.c, tests/api/test_mldsa.c, tests/api/test_mlkem.c, tests/api/test_ocsp.c, tests/api/test_pkcs7.c, tests/api/test_session.c and 28 more

Findings: 10
10 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11595

Scan targets checked: wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, tests/api/check-api-guards.py, tests/api/test_aes.h, tests/api/test_asn.h, tests/api/test_certman.h, tests/api/test_dh.h, tests/api/test_kdf.h, tests/api/test_mldsa.h, tests/api/test_pkcs7.h, tests/api/test_random.h, tests/api/test_session.h, tests/api/test_ssl_cert.h, tests/api/test_ssl_crl_ocsp.h, tests/api/test_ssl_ext.h, tests/api/test_tls.h, tests/api/test_tls13.h, tests/api/test_x509.h, tests/include.am, tests/unit-mcdc/mcdc_der_edit.h, tests/unit-mcdc/mcdc_fault_alloc.h and 4 more
Coverage: 5 of 10 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_asn.c, tests/api/test_random.c, tests/api/test_tls.c, tests/unit-mcdc/test_dtls_whitebox.c, tests/unit-mcdc/test_random_fault_whitebox.c

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11595

Scan targets checked: wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): .wolfssl_known_macro_extras, tests/api/check-api-guards.py, tests/api/test_aes.h, tests/api/test_asn.h, tests/api/test_certman.h, tests/api/test_dh.h, tests/api/test_kdf.h, tests/api/test_mldsa.h, tests/api/test_pkcs7.h, tests/api/test_random.h, tests/api/test_session.h, tests/api/test_ssl_cert.h, tests/api/test_ssl_crl_ocsp.h, tests/api/test_ssl_ext.h, tests/api/test_tls.h, tests/api/test_tls13.h, tests/api/test_x509.h, tests/include.am, tests/unit-mcdc/mcdc_der_edit.h, tests/unit-mcdc/mcdc_fault_alloc.h and 4 more
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

Two regressions from the class D fix, both biting in configs where the inner CID block and the DTLS 1.3 exporter sub-block compile together (--enable-all class): - test_tls.c: the dctx/dssl/cid decls landed mid-function when moved under the inner CID guard; move them to the top of the function under the full use condition (C90 mixed declarations). - test_tls13.c: the exporter-suite TLS 1.3 phase freed its ctx/ssl objects without NULLing the pointers, and test_memio_setup() only creates a ctx for NULL slots - the DTLS 1.3 phase reused the dangling ctx and wolfSSL_new() ran on freed memory (SIGSEGV / glibc robust-mutex abort). NULL the pointers at the free site. Verification: --enable-all with CPPFLAGS=-DWOLFSSL_RSA_KEY_CHECK -DHAVE_EX_DATA_CLEANUP_HOOKS builds clean and passes the full unit.test run.

philljj · 2026-11-05T15:34:42Z

tests good with multi-test with all-gcc-c89, c89-clang-tidy, c89-sanitize, wolfssl-all, no-malloc, sanitize-tls13, etc

philljj · 2026-11-05T18:50:27Z

Retest this please.

(fips ready apple m1)

Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:03

danielinux self-assigned this Sep 29, 2026

Copilot AI reviewed Sep 29, 2026

danielinux force-pushed the mcdc-part9-coverage branch 2 times, most recently from 746b129 to fe5628d Compare October 8, 2026 07:19

danielinux force-pushed the mcdc-part9-coverage branch from 0ca325e to 289b1e0 Compare November 3, 2026 11:33

danielinux force-pushed the mcdc-part9-coverage branch from c7a6782 to 9f305c6 Compare November 4, 2026 09:54

danielinux assigned wolfSSL-Bot and unassigned danielinux Nov 4, 2026

philljj requested a review from wolfSSL-Fenrir-bot November 4, 2026 15:55

wolfSSL-Fenrir-bot previously requested changes Nov 4, 2026

View reviewed changes

philljj reviewed Nov 4, 2026

View reviewed changes

Comment thread tests/unit-mcdc/test_tls_whitebox.c Resolved

philljj reviewed Nov 4, 2026

View reviewed changes

Comment thread tests/api/test_mlkem.c Resolved

philljj reviewed Nov 4, 2026

View reviewed changes

Comment thread tests/unit-mcdc/test_dtls_whitebox.c Resolved

philljj reviewed Nov 4, 2026

View reviewed changes

Comment thread tests/api/test_mldsa.c Resolved

philljj requested changes Nov 4, 2026

View reviewed changes

philljj assigned danielinux and philljj and unassigned wolfSSL-Bot Nov 4, 2026

danielinux requested a review from wolfSSL-Fenrir-bot November 4, 2026 16:40

wolfSSL-Fenrir-bot previously requested changes Nov 4, 2026

View reviewed changes

Comment thread tests/api/test_mldsa.c Resolved

danielinux requested a review from wolfSSL-Fenrir-bot November 4, 2026 17:03

wolfSSL-Fenrir-bot reviewed Nov 4, 2026

View reviewed changes

danielinux requested a review from philljj November 4, 2026 19:23

danielinux added 22 commits November 5, 2026 08:28

tests: fix campaign CI failures

f29a7b0

tests: fix remaining CI rows

e73d659

tests: gate AES decision rows in old FIPS

d5c4316

tests: register TLS white-box source

f1f2076

tests: fix FIPS and PKCS7 checks

4a6d403

tests: initialize AES GCM input

42a4c3e

Repair MC/DC drivers after master rebase

a8ac1bd

Fix DH nonblocking test warning after master rebase

619ae4e

Guard MC/DC test error paths against failed setup

4e5247a

Guard coverage tests for optional features and allocations

95705ea

Build DTLS cookie callback test without TLS 1.2

6c3924a

Free coverage test DER buffers and session references

c115a9c

Release context and certificate references in SetSSL_CTX coverage test

35d2d5f

Fix source checks and remove dead test assignment

504436e

Guard MC/DC coverage tests against missing AES modes, EMS, and DRBG

ad6d517

Fix PR review findings in coverage tests

0c65c1b

Construct ALPN whitebox fixture with owned storage

d543026

Address later PR review findings in coverage drivers

f825556

Free generated ML-DSA key before reuse in coverage test

c125bb2

Address review feedback on coverage guards and DER fixtures

9705a04

Guard coverage drivers across feature configurations

3e8884a

danielinux force-pushed the mcdc-part9-coverage branch from e9dffd7 to 3e8884a Compare November 5, 2026 07:29

danielinux requested a review from philljj November 5, 2026 09:00

danielinux added 2 commits November 5, 2026 18:11

Fix feature guards and coverage rows in MC/DC tests

b7e2b20

Avoid library-local CID parser in API test

5cc85af

philljj approved these changes Nov 5, 2026

View reviewed changes

philljj merged commit 375a3df into wolfSSL:master Nov 5, 2026
430 checks passed

Conversation

danielinux commented Sep 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report · Explore what changed →

Uh oh!

danielinux commented Nov 4, 2026

Uh oh!

danielinux commented Nov 4, 2026

Uh oh!

danielinux commented Nov 4, 2026

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11595

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11595

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11595

Uh oh!

philljj commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philljj commented Nov 5, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Sep 30, 2026 •

edited

Loading

philljj commented Nov 5, 2026 •

edited

Loading