Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression test can pass without exercising fragmentation when the generated ticket fits in one record.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds TLS 1.3 NewSessionTicket fragmentation to respect negotiated record limits.
Changes:
- Fragments oversized tickets across adjacent TLS records.
- Updates ticket-size rationale for resumed ClientHello messages.
- Adds a fragmentation and resumption test.
| File | Description |
|---|---|
src/tls13.c |
Implements ticket fragmentation. |
src/internal.c |
Updates the peer-certificate exclusion rationale. |
tests/api/test_tls13.c |
Adds the regression test. |
tests/api/test_tls13.h |
Registers the new test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
rizlik
reviewed
Oct 13, 2026
embhorn
force-pushed
the
gh11079
branch
3 times, most recently
from
October 16, 2026 19:14
7db1399 to
78a1446
Compare
Contributor
|
Retest this please. (fipsv2 test was disrupted) |
rizlik
reviewed
Oct 19, 2026
rizlik
previously approved these changes
Nov 3, 2026
Member
Author
|
Rebased to address conflicts |
Member
Author
|
retest this please |
SparkiDev
requested changes
Nov 6, 2026
| if (!ssl->options.dtls) { | ||
| maxFrag = wolfssl_local_GetMaxPlaintextSize(ssl); | ||
| if (maxFrag <= 0) | ||
| return (maxFrag < 0) ? maxFrag : BUFFER_E; |
Contributor
There was a problem hiding this comment.
Why return negative maxFrag?
Contributor
|
Fix conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Split the ticket into several records when it is larger than the negotiated max fragment length.
Fixes #11079
Testing
Added a regression test.
Checklist