Repository navigation
Skip the fwTPM RSA-PSS unit tests when wolfSSL is built without PSS - #667
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change that conditionally compiles RSA-PSS-specific tests.
No open issues 🎉
What changed in this PR
Updates fwTPM unit tests to support wolfSSL builds without RSA-PSS, addressing the fwtpm-v185-no-hkdf CI failure while preserving unrelated test coverage.
Changes:
- Guards RSA-PSS interoperability checks and their local variables with
WC_RSA_PSS, leaving OAEP tests enabled. - Guards the RSAPSS TestParms check while retaining the decrypt-key
nameAlgvalidation.
| File | Description |
|---|---|
tests/fwtpm_unit_tests.c |
Conditionally compiles PSS-specific tests without disabling OAEP or decrypt-key validation. |
Review effort: Balanced
embhorn
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
fwtpm-v185-no-hkdfCI job, which fails on master and on every open PR.That job builds wolfSSL without RSA-PSS (
--disable-hkdf, soWC_RSA_PSSis not defined). Since #661 the fwTPM itself builds that way.test_fwtpm_rsa_hash_interop, added in #656, callswc_RsaPSS_VerifyCheckandwc_RsaPSS_Sign_exunguarded, sotests/fwtpm_unit_tests.cfails to compile with an implicit declaration error. Behind that, the TestParms hash loop expectsTPM_ALG_RSAPSSto be accepted, which a build without PSS correctly rejects.test_fwtpm_rsa_hash_interopand its locals are under#ifdef WC_RSA_PSS; the OAEP half still runs.#ifdef WC_RSA_PSS. The decrypt key nameAlg check that follows it does not depend on PSS and still runs.When this broke
Only master is affected, no tagged release. The two PRs each passed CI on their own and conflicted only once both were merged: #661 (no PSS in the fwTPM, plus the no-hkdf CI job) merged first, then #656 (the interop test).