Skip to content

Skip the fwTPM RSA-PSS unit tests when wolfSSL is built without PSS - #667

Merged
embhorn merged 1 commit into
wolfSSL:masterfrom
dgarske:fwtpm_test_no_pss
Nov 3, 2026
Merged

embhorn merged 1 commit into
wolfSSL:masterfrom
dgarske:fwtpm_test_no_pss

Conversation

@dgarske

@dgarske dgarske commented Nov 3, 2026

Copy link
Copy Markdown
Member

Fixes the fwtpm-v185-no-hkdf CI job, which fails on master and on every open PR.

That job builds wolfSSL without RSA-PSS (--disable-hkdf, so WC_RSA_PSS is not defined). Since #661 the fwTPM itself builds that way. test_fwtpm_rsa_hash_interop, added in #656, calls wc_RsaPSS_VerifyCheck and wc_RsaPSS_Sign_ex unguarded, so tests/fwtpm_unit_tests.c fails to compile with an implicit declaration error. Behind that, the TestParms hash loop expects TPM_ALG_RSAPSS to be accepted, which a build without PSS correctly rejects.

  • The PSS sign and verify half of test_fwtpm_rsa_hash_interop and its locals are under #ifdef WC_RSA_PSS; the OAEP half still runs.
  • The RSAPSS TestParms check is under #ifdef WC_RSA_PSS. The decrypt key nameAlg check that follows it does not depend on PSS and still runs.

When this broke

Only master is affected, no tagged release. The two PRs each passed CI on their own and conflicted only once both were merged: #661 (no PSS in the fwTPM, plus the no-hkdf CI job) merged first, then #656 (the interop test).

Copilot AI balanced review requested due to automatic review settings November 3, 2026 21:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change that conditionally compiles RSA-PSS-specific tests.

No open issues 🎉

What changed in this PR

Updates fwTPM unit tests to support wolfSSL builds without RSA-PSS, addressing the fwtpm-v185-no-hkdf CI failure while preserving unrelated test coverage.

Changes:

  • Guards RSA-PSS interoperability checks and their local variables with WC_RSA_PSS, leaving OAEP tests enabled.
  • Guards the RSAPSS TestParms check while retaining the decrypt-key nameAlg validation.
File Description
tests/​fwtpm_unit_tests.c Conditionally compiles PSS-specific tests without disabling OAEP or decrypt-key validation.

Review effort: Balanced

@embhorn
embhorn merged commit 98b0b76 into wolfSSL:master Nov 3, 2026
245 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants