[kojiws]

Description

simulateFailureWithoutReboot() and simulateReloadFailure() used two static FLASH_RAM_SIZE buffers (2 MB of .bss). Embedded ports that link wh_test_nvm_flash.c only for whTest_Flash() carried this RAM even though these tests never ran there.

Changes

• Make liveMemory and liveBackup locals in the two functions, like in the neighbouring recovery tests.
• Peak stack use is unchanged.

Testing

• make run with NOCRYPTO=1
• make run with NOCRYPTO=1 ASAN=1 NVM_FLASH_CRC=1

[Copilot]

🟢 Approval recommended

No active review issues are reported for the flash-test buffer storage change.

No open issues 🎉

What changed in this PR

Moves the live-context flash test buffers from static storage to function-local stack storage, removing 2 MB of persistent .bss usage for embedded ports that link this test file only for whTest_Flash().

Changes:

• Removes the shared static liveMemory and liveBackup buffers.
• Adds zero-initialized local buffers to both failure-simulation functions, matching neighboring recovery tests.

File	Description
test/​wh_test_nvm_flash.c	Moves flash image buffers into simulateFailureWithoutReboot() and simulateReloadFailure().

_{Review effort: Balanced}

[bigbrett]

@kojiws 2MB on the stack probably isn't great either...

Should we instead just split the test up so the whTest_Flash() function is in its own module so it can be consumed by embedded targets if you want to run the test on them?

[kojiws]

@bigbrett
That looks better. I will create another PR to split whTest_Flash() out.