Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the serial-download fixes, signing-key preservation option, and expanded cleanup.
No open issues 🎉
What changed in this PR
This PR fixes i.MX8QM serial-download loading, adds an option to preserve signing keys, and broadens cleanup of wolfSSL port objects to prevent stale objects across configuration changes.
Changes:
- Uses the direct
uuu SDPS: bootcommand and supports selecting a board throughUUU_PATH. - Adds
KEEP_KEYS=1to preserve existing signing keys while retaining key regeneration by default. - Extends
make cleanto remove objects from all immediate wolfSSL port subdirectories.
| File | Description |
|---|---|
tools/scripts/imx8qm/imx8qm-mkflashbin.sh |
Skips key cleanup when KEEP_KEYS=1. |
tools/scripts/imx8qm/imx8qm-flash.sh |
Corrects the SDP command and adds optional USB-path selection. |
Makefile |
Broadens cleanup beyond Renesas port objects. |
docs/Targets.md |
Documents signing-key preservation and board selection. |
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #978
Scan targets checked: wolfboot-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
69214d5 to
95b7d7b
Compare
Description
Two small fixes, one for the i.MX 8QuadMax MEK scripts and one in the top-level Makefile.
1. i.MX8QM scripts
imx8qm-flash.sh sdpranuuu -b sdps, which current uuu releases reject ("sdps is not built-in script"). It now issues the protocol command directly,uuu SDPS: boot -f flash.bin. An optionalUUU_PATHpasses-mto uuu, so the load goes to the right board when more than one i.MX is in serial download mode.imx8qm-mkflashbin.shalways runsmake keysclean, so every run generates a new signing key and invalidates a FIT already signed on the boot medium.KEEP_KEYS=1skips the keysclean and builds against the key already in the tree. The default is unchanged.docs/Targets.mddocuments both.2. make clean leaves wolfSSL port objects
make cleanremovedwolfcrypt/src/*.oandwolfcrypt/src/port/Renesas/*.o, but not the other port directories, such as the ARMv8 assembly inport/arm. Those are only removed when the current config lists them inOBJS. Switching between configs in one tree could then fail to link (Transform_Sha512_Len_neonundefined) or link objects built for the previous config.cleannow removeswolfcrypt/src/port/*/*.o.Testing
KEEP_KEYS=1keeps the signing key acrossimx8qm-mkflashbin.shruns, and a default run still generates a new one. TheSDPS: boot -fform loaded containers on the i.MX8QM MEK. A build with the ARMv8 assembly enabled followed bymake cleannow leaves no port objects behind.