Skip to content

Fix i.MX8QM SDP loading and stale wolfSSL port objects after make clean - #978

Open
dgarske wants to merge 2 commits into
wolfSSL:masterfrom
dgarske:imx8qm_scripts
Open

dgarske wants to merge 2 commits into
wolfSSL:masterfrom
dgarske:imx8qm_scripts

Conversation

@dgarske

@dgarske dgarske commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description

Two small fixes, one for the i.MX 8QuadMax MEK scripts and one in the top-level Makefile.

1. i.MX8QM scripts

imx8qm-flash.sh sdp ran uuu -b sdps, which current uuu releases reject ("sdps is not built-in script"). It now issues the protocol command directly, uuu SDPS: boot -f flash.bin. An optional UUU_PATH passes -m to uuu, so the load goes to the right board when more than one i.MX is in serial download mode.

imx8qm-mkflashbin.sh always runs make keysclean, so every run generates a new signing key and invalidates a FIT already signed on the boot medium. KEEP_KEYS=1 skips the keysclean and builds against the key already in the tree. The default is unchanged. docs/Targets.md documents both.

2. make clean leaves wolfSSL port objects

make clean removed wolfcrypt/src/*.o and wolfcrypt/src/port/Renesas/*.o, but not the other port directories, such as the ARMv8 assembly in port/arm. Those are only removed when the current config lists them in OBJS. Switching between configs in one tree could then fail to link (Transform_Sha512_Len_neon undefined) or link objects built for the previous config. clean now removes wolfcrypt/src/port/*/*.o.

Testing

KEEP_KEYS=1 keeps the signing key across imx8qm-mkflashbin.sh runs, and a default run still generates a new one. The SDPS: boot -f form loaded containers on the i.MX8QM MEK. A build with the ARMv8 assembly enabled followed by make clean now leaves no port objects behind.

@dgarske dgarske self-assigned this Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 18:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the serial-download fixes, signing-key preservation option, and expanded cleanup.

No open issues 🎉

What changed in this PR

This PR fixes i.MX8QM serial-download loading, adds an option to preserve signing keys, and broadens cleanup of wolfSSL port objects to prevent stale objects across configuration changes.

Changes:

  • Uses the direct uuu SDPS: boot command and supports selecting a board through UUU_PATH.
  • Adds KEEP_KEYS=1 to preserve existing signing keys while retaining key regeneration by default.
  • Extends make clean to remove objects from all immediate wolfSSL port subdirectories.
File Description
tools/​scripts/​imx8qm/​imx8qm-mkflashbin.sh Skips key cleanup when KEEP_KEYS=1.
tools/​scripts/​imx8qm/​imx8qm-flash.sh Corrects the SDP command and adds optional USB-path selection.
Makefile Broadens cleanup beyond Renesas port objects.
docs/​Targets.md Documents signing-key preservation and board selection.

Review effort: Balanced

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #978

Scan targets checked: wolfboot-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 4 of 4 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants