Repository navigation
Misc. provider fixes - #92
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved authentication-failure handling, fork deadlocks, and worker cleanup errors prevent approval.
3 open findings
What changed in this PR
This PR hardens the wolfSSL GnuTLS provider’s error handling, authentication output, and shared random-number generation, addressing #89–#91.
Changes:
- Return negative errors for refused operations and correct MAC cleanup.
- Serialize shared RNG use and enforce exact-length RSA decryption.
- Correct GCM tag handling and add regression tests.
| File | Description |
|---|---|
| wolfssl-gnutls-wrapper/tests/test_util.h | Add refusal-or-output comparison helper. |
| wolfssl-gnutls-wrapper/tests/test_rsa_encrypt_and_decrypt.c | Test fixed-length decryption and unchanged failure buffers. |
| wolfssl-gnutls-wrapper/tests/test_pbkdf2.c | Test short-password handling. |
| wolfssl-gnutls-wrapper/tests/test_hmac.c | Test short-key handling. |
| wolfssl-gnutls-wrapper/tests/test_hkdf.c | Test short-salt handling. |
| wolfssl-gnutls-wrapper/tests/test_fips.c | Require negative RSA refusal errors. |
| wolfssl-gnutls-wrapper/tests/test_ecdsa_sign_and_verify.c | Test concurrent key generation and signing. |
| wolfssl-gnutls-wrapper/tests/test_aesgcm.c | Test tags after one-shot decryption. |
| wolfssl-gnutls-wrapper/tests/Makefile | Link threading support on Linux. |
| wolfssl-gnutls-wrapper/src/random.h | Expose RNG locking helpers. |
| wolfssl-gnutls-wrapper/src/random.c | Synchronize RNG use and refresh. |
| wolfssl-gnutls-wrapper/src/pk.c | Lock RNG operations and correct decryption lengths and errors. |
| wolfssl-gnutls-wrapper/src/mac.c | Correct refusal errors and context cleanup. |
| wolfssl-gnutls-wrapper/src/kdf.c | Return negative derivation errors. |
| wolfssl-gnutls-wrapper/src/cipher.c | Correct tag output and allocation checks. |
| wolfssl-gnutls-wrapper/Makefile | Enable provider threading support on Linux. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gasbytes
force-pushed
the
misc-improv-fixes
branch
2 times, most recently
from
October 15, 2026 11:51
4a56c17 to
92007a6
Compare
gasbytes
force-pushed
the
misc-improv-fixes
branch
from
October 15, 2026 12:13
92007a6 to
7464b44
Compare
gasbytes
requested review from
SparkiDev and
dgarske
and removed request for
SparkiDev
October 15, 2026 13:54
dgarske
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error handling, AEAD/RSA output and RSA thread-related fixes in the provider.
Fixes #89, #90, #91.
Tested locally with FIPS + gnutls 3.8.9...3.8.11.