Make Action.expires_at optional, so an action without a deadline need not invent one - #25
Merged
Merged
Conversation
…ed not invent one Rebuilt onto current master (branch had diverged at the root). Still needed: master's `schemas/booking.json` keeps `expires_at` in `Action.required`, so the gap this closes is open. CHANGE_LOG.md was the only conflict; both entries kept, newest-first. Also drops the accidentally committed .pyc and adds a .gitignore. schemas / refs / vectors / coherence all pass.
maoryeh
force-pushed
the
maoryeh/action-expires-at-optional
branch
from
September 21, 2026 11:59
bfaa439 to
43211b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actionrequiredtype,status,continue_urlandexpires_at. The last ofthose is the only one a conformant business can be unable to state truthfully:
an action that simply has no deadline has no value to put there, and the schema
left inventing one as the only way to validate.
The specification already settled this question the other way one level up.
Booking.expires_atis optional, and its description says why — "a businessthat does not hold slot capacity for a pending or requires_action booking MAY
omit this field" — because an advertised expiry is a claim the business must
then honour, and a business that enforces no deadline should not be made to
publish one. An action is in exactly that position. §8.5.4 even acknowledges the
asymmetry in passing: the payment-action clock is "independent of whether the
booking advertises
expires_at", and the action's expiry "SHOULD be no laterthan the booking's
expires_atwhen the booking advertises that field" —prose that already contemplates the booking having none, while the schema
refused the action the same freedom.
What an absent value means is now stated rather than left to the reader: the
business sets no deadline, and a platform MUST NOT infer one. The obligation
runs the other way for a business that will expire the action — it MUST
publish
expires_at, because a deadline the platform cannot see is one itcannot act on, and the buyer finds out about it only when the booking is
already canceled. Omitting the field is a statement about this business, not a
way out of §8.5.4.
Also reworded the two places in §5 that enumerated an action's fields as
"
type,status,continue_url,expires_at". Those read as a list of whatis always present, and they are the sentences an implementer checks before
opening the schema.
continue_urlis deliberately left REQUIRED. It is tempting to read §8.5.5's"not applicable to the
acporembeddedcheckout paths" as making itconditional too, but §8.5.4 says the opposite in terms: "Every action includes a
continue_url", and an embedded platform SHOULD send the buyer there forbuyer-side steps such as 3-D Secure "regardless of the declared
checkout_systemsvalue". It is the universal escalation hatch, not aredirect-mode field, and §8.5.5 scopes only the post-payment return mechanics.
schemas,refsandvectorspass.Found while auditing a Standalone
embeddedimplementation against the schema: it emits payment actions that genuinely have no deadline, and there was no conformant way to express that.🤖 Generated with Claude Code