Skip to content

Infra/update eslint to v7#3972

Merged
M-i-k-e-l merged 9 commits intoinfra/update-eslint-yarn-lock-14-04-26from
infra/update-eslint-to-v7
Apr 28, 2026
Merged

Infra/update eslint to v7#3972
M-i-k-e-l merged 9 commits intoinfra/update-eslint-yarn-lock-14-04-26from
infra/update-eslint-to-v7

Conversation

@M-i-k-e-l
Copy link
Copy Markdown
Collaborator

@M-i-k-e-l M-i-k-e-l commented Apr 15, 2026

Description

Major version v3 (to be safe)

eslint-rules - no-direct-import - Rename to clearer names
eslint-rules - upgrade eslint to v7
eslint-rules - function-deprecation - fix the fixer
eslint-rules - typography-deprecation - fix the fixer

package.json changes:
  - eslint: ^5.0.0 → ^7.0.0
  - eslint-config-standard: ^11.0.0 → ^16.0.0
  - eslint-plugin-import: ^2.9.0 → ^2.22.1
  - eslint-plugin-node: ^6.0.1 → ^11.1.0
  - eslint-plugin-promise: ^3.7.0 → ^5.0.0
  - Removed eslint-plugin-standard (no longer needed with eslint-config-standard@16)

  Test file changes (8 files):
  - parser: ‘babel-eslint’ → parser: require.resolve(‘babel-eslint’) — ESLint 7 requires absolute paths for parsers in RuleTester
  - Removed experimentalObjectRestSpread from ecmaFeatures, bumped ecmaVersion to 2018 (no-hard-coded-font test)
  - Added output property to 37 invalid test cases across all test files — ESLint 7 requires this when the rule has meta.fixable set

  Rule fix (function-deprecation.js):
  - Added a guard in the import specifier fixer to skip the fix when the target name already exists in the import, preventing the fixer from
  creating unparseable code with duplicate identifiers (ESLint 7 validates that autofixes produce valid code)

and two more fixes afterwards

Changelog

eslint-rules - update dependencies (including eslint to v7) - major version v3

Additional info

None

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

✅ PR Description Validation Passed

All required sections are properly filled out:

  • Description
  • Changelog
  • Additional info

Your PR is good for review! 🚀


This validation ensures all sections from the PR template are properly filled.

@M-i-k-e-l M-i-k-e-l removed the request for review from lidord-wix April 15, 2026 11:40
@M-i-k-e-l M-i-k-e-l requested a review from Copilot April 15, 2026 11:41
@M-i-k-e-l M-i-k-e-l review requested due to automatic review settings April 15, 2026 11:43
@M-i-k-e-l
Copy link
Copy Markdown
Collaborator Author

@adids1221 I've already done a review with Codex so LMK if you want me to "skip review"

@adids1221
Copy link
Copy Markdown
Contributor

@M-i-k-e-l you can use skip review, looks good

@adids1221 adids1221 assigned M-i-k-e-l and unassigned adids1221 Apr 26, 2026
@M-i-k-e-l M-i-k-e-l merged commit bed9a97 into infra/update-eslint-yarn-lock-14-04-26 Apr 28, 2026
4 of 5 checks passed
@M-i-k-e-l M-i-k-e-l deleted the infra/update-eslint-to-v7 branch April 28, 2026 06:30
M-i-k-e-l added a commit that referenced this pull request Apr 28, 2026
* Add verification and fix for other yarn.lock

* eslint-rules - update babel-eslint and remove unused deps

* eslint-rules - update eslint

* eslint-rules - update mocha

* Infra/update eslint to v7 (#3972)

* Rename to clearer names

* eslint-rules - upgrade eslint to v7

* eslint-rules - function-deprecation - fix the fixer

* eslint-rules - typography-deprecation - fix the fixer

* eslint-rules - bump major version

* Update yarn.lock

* eslint-rules - function-deprecation - fix the fixer (edge case from Codex)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants