Import participants from an existing group/channel while creating meeting [WPB-28117] - #22380
Open
zskhan wants to merge 1 commit into
Open
Import participants from an existing group/channel while creating meeting [WPB-28117]#22380zskhan wants to merge 1 commit into
zskhan wants to merge 1 commit into
Conversation
zskhan
force-pushed
the
feat/import-participants-from-existing-group
branch
from
September 3, 2026 21:10
284f0c8 to
81e4050
Compare
zskhan
force-pushed
the
feat/import-participants-from-existing-group
branch
from
September 3, 2026 21:13
81e4050 to
fd8e191
Compare
arjita-mitra
requested changes
Sep 7, 2026
| return ( | ||
| <> | ||
| <button | ||
| type="button" |
Contributor
There was a problem hiding this comment.
Add aria-expanded and aria-controls to the toggle button. Use a deterministic id so multiple pickers don't collide.
Example:
<button ... aria-expanded={isOpen} aria-controls={${id}-conversation-list} />
<div id={`${id}-conversation-list`} role="list">
arjita-mitra
requested changes
Sep 7, 2026
| const checkboxId = `${id}-${conversationKey}`; | ||
|
|
||
| return ( | ||
| <div key={conversationKey} css={listWrapper({noUnderline})}> |
Contributor
There was a problem hiding this comment.
Mark each conversation item as a listitem (role="listitem") or use semantic <ul>/<li>
You currently set role="list" on the container but the items lack role="listitem". This breaks list semantics for assistive tech.
<div key=... role="listitem" css=...>
| let userListContent: React.ReactNode = null; | ||
| if (isEmptyUserList && !hideEmptyState) { | ||
| userListContent = ( | ||
| <p className="user-list__no-results" data-uie-name={noResultsDataUieName}> |
Contributor
There was a problem hiding this comment.
When search results change, screen readers must be informed about the no matches messages. The current no results paragraph is just static <p>.
Add role="status" and aria-live="polite"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.