Skip to content

fix: notify-rm refused token, changelog feat!, build-image index expiry - WPB-29305 - #5

Open
bsinou wants to merge 2 commits into
devfrom
fix/wpb-29305-v0.1.1
Open

bsinou wants to merge 2 commits into
devfrom
fix/wpb-29305-v0.1.1

Conversation

@bsinou

@bsinou bsinou commented Nov 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Three small fixes for v0.1.1.

notify-rm. When the release manager refused the token of a repository (HTTP 401 or 403), the step only logged answered 403: <component> <version> not declared there. A repository not yet bound in the release manager, the wire-account case (green build, nothing declared), looked like any other outage. Now the warning names the repository (GITHUB_REPOSITORY and its id) and says what to fix. In OIDC mode the release manager doesn't know the repository or doesn't let it declare the component: add it to oidc.repositories in config/components.yaml and redeploy. With an ingest token, the token is expired, revoked or bound to another component. The job summary carries the same text.

changelog. feat!: … went to Other Changes and feat(api)!: … was dropped entirely. Both now land under Breaking Changes, like [breaking].

build-image. quay.expires-after was a label only, and annotations went to the index only for multi-platform builds. But buildx pushes an index as soon as it attaches provenance or SBOM attestations (our default), and for an index Quay reads the expiry from the annotation, not from the label. So dev images never expired. The expiry is now also an annotation, on the index whenever there is one.

How: scripts/notify-rm.sh remembers which credential it sent and handles 401/403 before the generic warning (the response body still sits between stop-commands). scripts/changelog.sh strips the ! before the generate-changelog parse and marks the commit as breaking. scripts/build-image.sh picks index,manifest when the build is multi-platform or has attestations. Tests cover all three, and the READMEs describe the new behaviour.

Related Issue

  • WPB-29305

Types of changes

  • 🐞Bug fix – A non-breaking change that resolves an existing issue.
  • ✨New feature – A non-breaking change that introduces new functionality
  • 💥Breaking change – A change that alters existing functionality in a way that is not backward compatible.
  • 🧼Code Cleanup - Code refactoring or improvements with no functional impact.
  • 📖Documentation – Updates or additions to documentation only.
  • 🛠️Tooling - fix or add tools in the repository to build / lint / ...

@bsinou
bsinou requested a review from a team as a code owner November 7, 2026 08:26
@bsinou
bsinou force-pushed the fix/wpb-29305-v0.1.1 branch from 558e574 to 437336b Compare November 7, 2026 08:53
@bsinou
bsinou force-pushed the fix/wpb-29305-v0.1.1 branch from 437336b to bc7a495 Compare November 7, 2026 09:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant