Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release mode (
release-version.sh) takes a pre-release numbered 0 as an anchor:v5.1.0-alpha.0on the last production commit makes the next alpha5.1.0-alpha.1. Build mode (compute-version.sh) skipped those tags, because its pre-release pattern starts at 1. So a branch whose only reachablevtag is an anchor failed every dev build with "no GA or pre-release tag is reachable". It happened on wire-avs-service, onrelease/5.1anddev.Dev builds now accept
X.Y.Z-alpha|beta|rc.0when they look for the nearest tag, and come out as5.1.0-alpha.0.<ts>.g<sha7>. A tag build of an anchor is still refused:.0opens a line but is never a version.When several tags point at the nearest commit, the highest in SemVer now wins, as in release mode. A GA still beats its own pre-releases (
v5.3.0overv5.3.0-rc.2). An anchor now beats an older GA on the same commit (v5.1.0-alpha.0overv5.0.80), where the old rule picked the GA and built5.0.81-...while release mode prepared5.1.0-alpha.1.Two new tests cover a dev build after an anchor and an anchor next to an older GA.
version/README.mdgets the anchor rule and a row in the table.make cipasses.Related Issue
Types of changes