Skip to content

feat: update sorting icon display (WPB-27860) #5254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohassine merged 5 commits into from
Sep 7, 2026
+3 −2
Merged

feat: update sorting icon display (WPB-27860) #5254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e00164
feat: Show active 'Newest first ↓' filter by default in Drive
ohassine Sep 4, 2026
dc1bbfe
chore: test
ohassine Sep 7, 2026
bf19408
fix: inverted sorting
ohassine Sep 7, 2026
1ab7d6b
Merge branch 'develop' into show-right-icon-for-sorting
ohassine Sep 7, 2026
b3c7218
chore: test
ohassine Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ures/cells/src/main/java/com/wire/android/feature/cells/ui/search/sort/SortingCriteria.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
) : SortingCriteria {
override val by: SortBy = SortBy.Modified

data object NewestFirst : ByDate(R.string.sort_modified_newest_first, SortDirection.Desc)
data object OldestFirst : ByDate(R.string.sort_modified_oldest_first, SortDirection.Asc)
data object NewestFirst : ByDate(R.string.sort_modified_newest_first, SortDirection.Asc)
data object OldestFirst : ByDate(R.string.sort_modified_oldest_first, SortDirection.Desc)

Check warning on line 59 in features/cells/src/main/java/com/wire/android/feature/cells/ui/search/sort/SortingCriteria.kt

View check run for this annotation

Codecov / codecov/patch

features/cells/src/main/java/com/wire/android/feature/cells/ui/search/sort/SortingCriteria.kt#L59 

Added line #L59 was not covered by tests
}

sealed class ByName(
Expand Down
1 change: 1 addition & 0 deletions features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ class CellViewModelTest {
any(),
any(),
match { it.criteria == KaliumSortingCriteria.NAME_CASE_SENSITIVE && !it.descending },
any()
)
}
}
Expand Down
Loading