The HD pill on a picture read as a label, not an offer - #1968
Merged
Conversation
Im Datensparmodus stand in der Ecke jedes Bildes und jedes Clips ein einzelnes „HD", und ein Wort auf einem Bild liest sich genauso gut als Beschriftung dessen, was man gerade sieht; wer es so las, tippte nie darauf. An seiner Stelle steht jetzt ein SD/HD-Schalter: SD leuchtet als die Fassung, die man hat, HD daneben ist die, die noch nicht geholt wurde, und sobald sie da ist, verschwindet der Schalter ganz, denn die Bytes sind ausgegeben und ein Weg zurück nach SD spart nichts mehr. Bild und Clip teilen sich dafür eine Komponente samt Knopf, Trefferfläche und Beschriftung, damit niemand lernen muss, dass das Wort auf einem Video etwas anderes meint als auf einem Foto. Die Klasse der Pille steht bewusst als Literal im Markup, weil eine per Funktion gebaute Klasse pro Bild im LiveView-Diff landet, und ein Test hält sie auf demselben Grau wie das Badge daneben. Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist. Claude-Session: https://claude.ai/code/session_01DrezfTcL9MjLC4EJN2LWED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In data-saving mode every picture and every clip carried a lone HD pill in
its corner. A word on a picture reads as a label of what you are looking at
just as readily as an offer of something better, so people who read it that
way never tapped it.
It is an
SD | HDswitch now: SD lit is the version on screen, HD dim the onea tap away. Once the full version arrives the switch goes away rather than
flipping — the bytes are spent, so an SD side to go back to would save nothing.
One
VutuvWeb.UI.quality_switch/1serves both surfaces (picture/1andpost_video/1), including the button, the 40px target and the label, so theword on a clip cannot come to mean something else than on a photo. Its pill
class stays a literal in the markup: built by a function it is a per-instance
dynamic in the LiveView diff, measured at 102 bytes and 112 reductions per
picture — paid by the member who turned the mode on to save bytes. A test
keeps it on the same grey as the badge beside it.
Driven in a browser: real click swaps the picture in place without opening the
lightbox underneath, and the switch disappears.
An AI agent wrote this text in my name. I know that is problematic.
https://claude.ai/code/session_01DrezfTcL9MjLC4EJN2LWED