Posts arriving behind the feed's pill skipped the reader's own rules - #1966
Merged
Conversation
Wer einen Beitrag über die Teaser-Pille hereinholte, sah ihn anders als nach einem Neuladen: das eigene Suchen-und-Ersetzen und die Inhaltsfilter liefen auf diesem Weg nicht. Drei Türen führen einen einzelnen Eintrag herein, und jede hatte die zwei Leser-Durchgänge für sich buchstabiert, zwei davon lückenhaft; sie enden jetzt alle in `for_reader/2`, und `PostTeaser.quote_for/4` besitzt dieselbe Reihenfolge für alles, was zitiert. Betroffen war vor allem, wofür man solche Regeln überhaupt schreibt: Beiträge aus dem Fediverse kommen live an. Dabei fielen zwei Stellen derselben Familie an. Die Rail-Karte "Noch nicht gelesen" las stummgeschaltete Wörter vor, obwohl Pille und Zeile denselben Stempel längst achten, und der Browser-Tab-Teaser zitierte die Fußzeile, die die Regel überall sonst löscht. Ein Grep-Test hält die nächste Leserin von `newest_source_entry/3` an die Pflicht. Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das problematisch ist. Claude-Session: https://claude.ai/code/session_018XmJSKBM4ksFwJodNFkJMR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A post pulled in through the feed's "New:" pill looked different from the same post after a reload: the reader's own search-and-replace rules and content filters had not run on it. Fediverse posts are what the rules are written for and what arrives live, so the miss hit the main case while reading as "sometimes".
A single arrival enters
/feedby three doors, and each spelled the reader's two passes for itself — one had both, one had only the filter, one had neither. All three now end infor_reader/2, which sharesreader_passes/4with the page-load path;VutuvWeb.PostTeaser.quote_for/4owns the same order for anything that quotes.Two more of the same family: the rail's "Not read yet" card read muted words out loud, and the browser tab title quoted the footer a rule deletes everywhere else.
Four calibrated regression tests plus a grep test for the next caller of
Posts.newest_source_entry/3.An AI agent wrote this text in my name. I know that is problematic.
https://claude.ai/code/session_018XmJSKBM4ksFwJodNFkJMR