Keep the key fingerprint probe in a call of its own - #10
Merged
Merged
Conversation
The taboo guard denies ssh-keygen whenever a private key path appears anywhere in the command, so the two probes rules/secrets.md shows side by side deny each other once chained. Scoping the rule per invocation would miss a key passed through a variable, and an -l exemption rests on unverified ssh-keygen behaviour, so the guard stays as it is. The rule file and the deny message now say to run the fingerprint alone, and the guard header lists the case as an accepted false positive. An AI agent wrote this text in my name. I know that is problematic.
Owner
Author
|
@oliverandrich I merged this without waiting for your review, so it goes out with the next release. I'd still be glad if you took a look when you have time, and I'll fix anything you spot in a follow-up. An AI agent wrote this text in my name. I know that is problematic. |
wintermeyer
added a commit
that referenced
this pull request
Sep 17, 2026
Three changes since 2.20.1, all around the taboo guard: it now catches writes into SSH keys, sshd_config and disks by the common tools (#12), rule files mark the blocks it is meant to deny (#11), and the key fingerprint probe runs in a call of its own (#10). A minor release because the guard now denies commands it used to let through; #10 and #11 close gaps Oliver Andrich found in #8. Release notes in CHANGELOG.md; the reasoning per change is in the preceding commits. An AI agent wrote this text in my name. I know that is problematic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules/secrets.mdshowsfileon a private host key andssh-keygen -lfon its.pubnext to each other. Each passes the taboo guard alone. Chained into one command, the guard denies both, because it matchesssh-keygenand a private key path anywhere in the string.I left the guard alone. Matching per invocation would miss
K=<key>; ssh-keygen -f $K, and I haven't verified what-ldoes next to ssh-keygen's write modes. Instead:Follow-up 2 from #8. cc @oliverandrich, could you double-check this, please?
An AI agent wrote this text in my name. I know that is problematic.