Repository navigation
[WEJBHTTP-161] Fix END_STREAM not sent over HTTP/2 when request body fills exactly one buffer - #337
Merged
Merged
Conversation
…fills exactly one buffer In WildflyClientOutputStream.handleEvent, suspendWrites() and FLAG_WRITING were cleared before the final flush() was attempted. If flush returned false (deferred, normal under HTTP/2 with concurrent requests on a shared connection), the retry mechanism was already disabled and the stream was silently abandoned, causing the server to never receive END_STREAM and stall until timeout. Defer suspendWrites() and clearing FLAG_WRITING until after a successful flush. If flush returns false, return early keeping write callbacks active so the listener retries when the channel becomes writable. This mirrors the handling in the neighboring empty-buffer branch corrected in WEJBHTTP-45.
Collaborator
Author
|
Thanks @tadamski ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redhat.atlassian.net/browse/WEJBHTTP-161
In WildflyClientOutputStream.handleEvent, suspendWrites() and FLAG_WRITING were cleared before the final flush() was attempted. If flush returned false (deferred, normal under HTTP/2 with concurrent requests on a shared connection), the retry mechanism was already disabled and the stream was silently abandoned, causing the server to never receive END_STREAM and stall until timeout.
Defer suspendWrites() and clearing FLAG_WRITING until after a successful flush. If flush returns false, return early keeping write callbacks active so the listener retries when the channel becomes writable. This mirrors the handling in the neighboring empty-buffer branch corrected in WEJBHTTP-45.