#7 Add support for session expiration - #8
Open
tomisaacson wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
- Update README.md?
I've also included support for AWS_SESSION_EXPIRATION my branch, but it's on top of PR #10 and a pending PR
Virgil
| fi | ||
|
|
||
| if [[ "${SHOW_KEY}" = false && "${SHOW_SECRET}" = false && "${SHOW_SESSION_TOKEN}" = false ]]; then | ||
| if [[ "${SHOW_KEY}" = false && "${SHOW_SECRET}" = false && "${SHOW_SESSION_TOKEN}" = false && "${SHOW_EXPIRATION}" = false ]]; then |
There was a problem hiding this comment.
$SHOW_EXPIRATION is probably meant to be $SHOW_SESSION_EXPIRATION
Owner
|
@tomisaacson I've been convinced to add this as part of #10. Sorry to pass over your PR, which was first. Would you mind reviewing #10 instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.