Skip to content

fix(siwe): parse resources from the resources section - #478

Merged
jxom merged 1 commit into
0.xfrom
jxom/siwe-resources-v0
Sep 26, 2026
Merged

jxom merged 1 commit into
0.xfrom
jxom/siwe-resources-v0

Conversation

@jxom

@jxom jxom commented Sep 26, 2026

Copy link
Copy Markdown
Member

Read Siwe.parseMessage resources from the trailing Resources: section, preserving lists when the marker appears inside other fields or resource URIs. Handle empty request IDs.

Ports wevm/viem#5132.

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Building Building Preview Sep 26, 2026 11:47am UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/ox@478

commit: 5def70f

@jxom
jxom marked this pull request as ready for review September 26, 2026 11:49
@jxom
jxom merged commit 17b4308 into 0.x Sep 26, 2026
8 of 14 checks passed
@jxom
jxom deleted the jxom/siwe-resources-v0 branch September 26, 2026 11:49
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T11:51:30.751519Z 5def70f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch was successfully deployed

1 active deployment
Preview — 5def70f5 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant