Skip to content

fix(siwe): parse resources from the resources section - #477

Merged
jxom merged 1 commit into
mainfrom
jxom/siwe-resources-main
Sep 26, 2026
Merged

jxom merged 1 commit into
mainfrom
jxom/siwe-resources-main

Conversation

@jxom

@jxom jxom commented Sep 26, 2026

Copy link
Copy Markdown
Member

Read Siwe.parseMessage resources from the trailing Resources: section, preserving lists when the marker appears inside other fields or resource URIs. Handle empty request IDs.

Ports wevm/viem#5132.

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ox Building Building Preview Sep 26, 2026 11:47am UTC

Request Review

@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/ox@477

commit: df6c173

@jxom
jxom marked this pull request as ready for review September 26, 2026 11:49
@jxom
jxom merged commit 10075a8 into main Sep 26, 2026
7 of 16 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T11:51:04.859440Z df6c173 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jxom
jxom deleted the jxom/siwe-resources-main branch September 26, 2026 11:49
@github-actions github-actions Bot mentioned this pull request Sep 26, 2026

This branch had an error being deployed

1 failed deployment
Preview — df6c1737 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant