feat: align frame rpc definitions - #475
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69e45387dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| data: Hex.Hex | ||
| /** Execution gas budget. */ | ||
| executionGasLimit: Hex.Hex | ||
| executionGas: Hex.Hex |
There was a problem hiding this comment.
When users follow the RPC conversion guide, it still says executionGas becomes executionGasLimit, stateGas becomes stateGasLimit, and that modes, flags, and signature schemes are numbers (site/pages/guides/frame-transactions.md:118-122). This change now emits executionGas/stateGas and hex quantities for all three values, so manually constructed requests based on the guide will no longer match Frame.Rpc and may be rejected by the node; update that guide alongside these public RPC changes.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Align frame RPC quantities, signature placeholders, and receipt gas totals with ethereum/execution-apis#907. Run frame integration tests against the Reth branch from paradigmxyz/reth#27430.