Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jxom
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c9c1f520d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| requireFunds?: | ||
| | readonly FundingRequirement.FundingRequirement<bigintType, numberType>[] | ||
| | undefined |
There was a problem hiding this comment.
target
When consumers use the exported TxEnvelopeTempo.Rpc type, this generic requirement becomes FundingRequirement<Hex.Hex, Hex.Hex>, whose sources still use the domain field to. The node RPC representation introduced here is instead FundingRequirement.Rpc, with sources shaped as { target, data }, as reflected by FundingRequirement.toRpc/fromRpc. Consequently, a valid RPC envelope containing requireFunds is not assignable to TxEnvelopeTempo.Rpc, while the type incorrectly accepts envelopes using the non-RPC to field; override this property in the Rpc alias with FundingRequirement.Rpc[].
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4eb6793a43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ...(limits !== undefined ? { limits } : {}), | ||
| ...(scopes !== undefined ? { scopes } : {}), | ||
| ...(witness !== undefined ? { witness } : {}), | ||
| ...(rawFundingPolicy !== undefined |
There was a problem hiding this comment.
When decoding a key authorization whose seventh optional slot is explicitly 0x (the RLP-null placeholder used for skipped trailing fields), this condition passes the marker to FundingPolicy.fromTuple, which rejects it as an invalid policy ID. The surrounding decoder deliberately treats 0x as absent for every other optional slot, so a full-width encoding with no funding policy cannot be deserialized; use isAbsent(rawFundingPolicy) here as well.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Added TIP-1120 funding requirements, policy commitments, and access key funding authorization to
0.x, includingFundingRequirement.from()and native DEX codecs.Backports #468 using existing v0 tooling.