Repository navigation
docs(swift): write changesets in the past tense - #156
Merged
Merged
Conversation
Changesets for lexical-swift were written in the present tense ("`LexicalList` keeps …"). At tmm's request they are now written in the past tense, starting with what was done ("Added …", "Changed …", "Fixed …", "Removed …"). swift/.changeset/README.md states the rule and its example follows it, and swift/AGENTS.md's Changesets section repeats it. Released CHANGELOG.md sections are not rewritten.
Docs only, so no changeset. Checked with `npx prettier --check swift/.changeset/README.md swift/AGENTS.md` (all matched files use Prettier code style). README.md is excluded from the changesets that swift/scripts/version-packages.sh and swift-release.yml consume, so this opens no version PR.
Amp-Thread-ID: https://ampcode.com/threads/T-01a19fce-8f8f-751a-afa3-961a37bb1a98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changesets for
lexical-swiftwere written in the present tense ("LexicalListkeeps …"). At tmm's request, they're now written in the past tense and start with what was done: "Added …", "Changed …", "Fixed …", "Removed …".swift/.changeset/README.mdstates the rule, and its example now follows it.swift/AGENTS.md's Changesets section repeats the rule.CHANGELOG.mdsections are left as they were written.This is docs only, so it has no changeset.
README.mdis excluded from the changesets thatswift/scripts/version-packages.shandswift-release.ymlconsume, so merging this opens no version PR.Checks
npx prettier --check swift/.changeset/README.md swift/AGENTS.mdreported: "All matched files use Prettier code style!"