Repository navigation
ci(swift): stop cancelling Swift (macOS) runs on main - #148
Merged
Merged
Conversation
Five main runs in a row (e847b6d to 59c4205) were cancelled while still waiting for a runner, because each merge cancelled the run before it, so main had no finished Swift (macOS) run and the version pull request had nothing to gate on. Pull requests still cancel superseded runs; on main a started run finishes and GitHub keeps only the newest waiting one. Amp-Thread-ID: https://ampcode.com/threads/T-676d84e9-fb85-4087-aa34-c1b89aa8ad87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #130, which made a newer push to main cancel the Swift (macOS) run of an older one.
What changes
Main merges land faster than macOS runners free up: the runs on e847b6d (#130), db0b1d2 (#133), e775fd7 (#127), 77b35a8 (#136) and 59c4205 (#138) were all cancelled while still queued, so main has had no finished Swift (macOS) run, and the version pull request, which now gates on main's run at its base commit, had nothing to check.
cancel-in-progressgoes back to pull requests only (as before #130). On main a started run finishes, and GitHub's concurrency group keeps only the newest waiting run, so at most two runs per burst of merges. Pull requests still cancel superseded runs.How it was checked