Repository navigation
[6.0] #3582 Avoid repeating per-class work while processing annotated types - #3584
Merged
Merged
Conversation
lprimak
force-pushed
the
with-annotations-filter-perf-6.0
branch
from
October 29, 2026 02:22
77ca456 to
94a9030
Compare
lprimak
changed the title
- RequiredAnnotationDiscovery searched the whole class hierarchy once for each annotation that a @WithAnnotations observer asks for. A class is now searched once, and the result is kept until bootstrap is finished. - EnhancedAnnotatedTypeImpl#getOverriddenMethods went through all methods of a type again for every class in its hierarchy. The methods are now grouped by their declaring class once. The results are the same as before. This is an optimization. Signed-off-by: lprimak <lenny@flowlogix.com>
lprimak
force-pushed
the
with-annotations-filter-perf-6.0
branch
from
November 3, 2026 18:51
c4f5d43 to
7c7c1d4
Compare
manovotn
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6.0 backport of #3583.
Same change and tests as in #3583 (see #3582 for the problem). It applies without changes.
mvn testinimplon this branch passes (291 tests, including the two new test classes).