Skip to content

fix: upgrade go version to 1.26.6 - #2738

Closed
kristina-solovyova wants to merge 1 commit into
08-15-fix_make_spec.overrides.paused_work_again_op-375_from
08-15-fix_upgrade_go_version_to_1.26.6
Closed

fix: upgrade go version to 1.26.6#2738
kristina-solovyova wants to merge 1 commit into
08-15-fix_make_spec.overrides.paused_work_again_op-375_from
08-15-fix_upgrade_go_version_to_1.26.6

Conversation

@kristina-solovyova

Copy link
Copy Markdown
Collaborator

No description provided.

@kristina-solovyova
kristina-solovyova marked this pull request as ready for review August 15, 2026 12:37
@kristina-solovyova
kristina-solovyova requested a review from a team as a code owner August 15, 2026 12:37
@graphite-app
graphite-app Bot requested review from assafgi and tigrawap August 15, 2026 12:37
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

kristina-solovyova commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator Author

How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude

claude Bot commented Aug 15, 2026

Copy link
Copy Markdown

Claude finished @kristina-solovyova's task in 1m 36s —— View job


Review: go 1.26.5 → 1.26.6

  • Fetch and read the PR diff (4 files, mechanical version bump)
  • Sweep the repo for every other place the Go version is pinned
  • Check parent PR fix: make spec.overrides.paused work again (OP-375) #2737 for overlap (unrelated — spec.overrides.paused; no interaction with this change)
  • Post findings

Findings

One missed pin — image.Dockerfile (medium)

image.Dockerfile:1 is still FROM ... golang:1.26.5, while go.mod now declares go 1.26.6. This matters more than it looks: image.Dockerfile is the builder used for actual releases (build-release.sh:75 and :78 both pass -f image.Dockerfile), whereas the Dockerfile bumped in this PR carries the in-tree note "right now this image is not in use".

It won't hard-fail today — image.Dockerfile doesn't set GOTOOLCHAIN, so the 1.26.5 toolchain will auto-download 1.26.6 from the module proxy (the buildkit /go/pkg/mod cache mount will hold it between builds). But that means the release image is built by an unpinned, silently-fetched toolchain, and it breaks hard as soon as GOTOOLCHAIN=local reaches that build. Suggest bumping it here. Fix this →

Sync-checklist comment is incomplete (minor)

The go.mod comment at lines 3-6 lists only Dockerfile and .dagger/.../builders.py. It omits both image.Dockerfile and .tool-versions — which is plausibly why .tool-versions had drifted all the way back to 1.26.3 before this PR corrected it. Suggested replacement posted inline on go.mod.

Verified clean

  • .tool-versions, Dockerfile, .dagger/src/containers/builders.py, go.mod are now mutually consistent at 1.26.6.
  • All six actions/setup-go steps across build.yaml, package.yaml, run_upgrade_test.yaml use go-version-file: go.mod, so they follow the bump automatically — no workflow edits needed (which is good, since I can't modify .github/workflows).
  • The remaining 1.26.x hits in Makefile:64, .github/workflows/build.yaml:177, test/services/kubernetes.go:68, internal/controllers/test/suite_test.go:89 are all 1.26.0 envtest/kubebuilder K8s versions — unrelated coincidence, correctly left alone.
  • bundle.Dockerfile and docker-bake.hcl contain no Go pins.
  • A patch-level go directive (go 1.26.6) is valid and intended here given the GOTOOLCHAIN=local setup. No security or performance implications beyond picking up upstream patch fixes.

Not done

I did not run make test or a build — this is a toolchain bump whose only real verification is CI on a machine with go 1.26.6 available, and the local checkout has the pkg/weka-k8s-api and pkg/go-steps-engine submodules uninitialized, so a local build would fail for unrelated reasons. I made no code changes; the image.Dockerfile bump is left as a suggestion rather than pushed, since this was a review request.
· branch 08-15-fix_upgrade_go_version_to_1.26.6

Comment thread go.mod
@graphite-app

graphite-app Bot commented Aug 15, 2026

Copy link
Copy Markdown

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (08/15/26)

2 reviewers were added to this PR based on Anton Bykov's automation.

@kristina-solovyova
kristina-solovyova force-pushed the 08-15-fix_upgrade_go_version_to_1.26.6 branch from c0f4dca to 89dce4e Compare August 15, 2026 12:41
@weka weka deleted a comment from claude Bot Aug 15, 2026
@kristina-solovyova
kristina-solovyova force-pushed the 08-15-fix_upgrade_go_version_to_1.26.6 branch from 89dce4e to c70e37c Compare August 15, 2026 12:52
@claude

claude Bot commented Aug 15, 2026

Copy link
Copy Markdown

Claude finished @kristina-solovyova's task in 35s —— View job


Review: go 1.26.5 → 1.26.6 (re-review after push)

  • Diff the new push against the previous review
  • Confirm both prior findings are resolved
  • Re-sweep the repo for any remaining Go version pin

Both prior findings resolved

image.Dockerfile bumpedimage.Dockerfile:1 is now golang:1.26.6, matching go.mod. This was the important one: it's the builder that produces the released image (build-release.sh:75,78), so the release path no longer depends on a silent toolchain download from the module proxy.

Sync checklist completed — the go.mod note (lines 3-11) now lists all four pin sites including image.Dockerfile (helpfully annotated as "the image actually released") and .tool-versions, plus the go-version-file: go.mod clarification for CI and a grep recipe for catching future drift. That's a better fix than my suggestion — the grep makes the checklist self-verifying rather than just longer.

I ran the suggested grep as written; it correctly surfaces all four pins. Only noise is one hit on builders.py:162 (uv:alpine, from the alpine" clause) — harmless.

Verified consistent at 1.26.6

File Value
go.mod:12 go 1.26.6
image.Dockerfile:1 golang:1.26.6
Dockerfile:3 golang:1.26.6
.dagger/src/containers/builders.py:9 1.26.6-alpine
.tool-versions:1 golang 1.26.6

Remaining 1.26.x matches (Makefile:64, .github/workflows/build.yaml:177, test/services/kubernetes.go:68, internal/controllers/test/suite_test.go:89) are all 1.26.0 envtest/kubebuilder Kubernetes versions — coincidental version overlap, correctly untouched.

No new issues. No further comments from me — LGTM.

Not done

No build or make test run: the only meaningful verification of a toolchain bump is CI on a host with go 1.26.6, and this checkout has the pkg/weka-k8s-api / pkg/go-steps-engine submodules uninitialized, so a local build would fail for unrelated reasons. I made no code changes.
· branch 08-15-fix_upgrade_go_version_to_1.26.6

@graphite-app

graphite-app Bot commented Aug 16, 2026

Copy link
Copy Markdown

Merge activity

  • Aug 16, 9:18 AM UTC: kristina-solovyova added this pull request to the Graphite merge queue.
  • Aug 16, 9:19 AM UTC: CI is running for this pull request on a draft pull request (#2739) due to your merge queue CI optimization settings.
  • Aug 16, 10:13 AM UTC: Merged by the Graphite merge queue via draft PR: #2739.

@graphite-app graphite-app Bot closed this Aug 16, 2026
@graphite-app
graphite-app Bot deleted the 08-15-fix_upgrade_go_version_to_1.26.6 branch August 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants